Add expert evaluation backend flow - #670
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Что изменено
Roadmap
Roadmap-IDs: DEV-050, DEV-051, DEV-052
Roadmap-Complete: DEV-050, DEV-051, DEV-052
Roadmap-Partial:
API
GET /expert/submissions/GET /expert/submissions/<submission_id>/GET /submissions/<submission_id>/evaluations/my/POST /submissions/<submission_id>/evaluations/GET/PATCH /evaluations/<evaluation_id>/POST /evaluations/<evaluation_id>/submit/GET /programs/<program_id>/evaluations/GET /programs/<program_id>/evaluations/<evaluation_id>/GET /programs/<program_id>/submission-assignments/.Права доступа
Expert endpoints требуют текущий program membership и assignment
assigned/completed; mutation draft требуетassigned. Чужие и неназначенные объекты скрываются через 404. Manager endpoints ограничены своей Program, staff сохраняет административный read-only доступ. Expert serializer не возвращает Application/participant/Team/form_data/email/phone и Evaluation других экспертов.Проверка
manage.py check --tag models— passed.manage.py makemigrations --check --dry-run --skip-checks— No changes detected.procollab/settings.pyне переформатирован, чтобы избежать unrelated churn.git diff --check— passed.localhost:5432, настройки БД не менялись.Риски и ограничения
total_scoreостаетсяnull: формула Program не реализуется в этом контуре.Submission.form_dataцеликом исключен из expert detail, поскольку надежного solution-only allowlist пока нет.select_for_update; SQLite CI не проверяет row-level locking.