fix: send real password reset link instead of dummy route - #129
Open
Kanavpreet-Singh wants to merge 1 commit into
Open
fix: send real password reset link instead of dummy route#129Kanavpreet-Singh wants to merge 1 commit into
Kanavpreet-Singh wants to merge 1 commit into
Conversation
Kanavpreet-Singh
had a problem deploying
to
dockerhub
August 13, 2026 03:40 — with
GitHub Actions
Failure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Password reset emails contained the literal string
dummyFrontEndRoute?token=<uuid>instead of a usable link, so no user could ever complete a reset.
verify.base.frontendwas already defined inapplication.ymlbut was read bynothing — the only
@Valuein the whole codebase wasjwt.secret.Changes
EmailServicenow builds the real link fromverify.base.frontendplus a newverify.reset.pathproperty, pointing at the existing frontend route/forgot-password/change-password?token=(seepages/forgot-password/change-password.tsxin the website repo, which already reads
tokenfrom the query string).setFrom. Gmail silently substitutes the authenticatedaccount, which is why nobody noticed; any other SMTP server rejects the message
with
553 5.1.3 The address is not a valid RFC 5321 address. This matters if weever move off Gmail.
existing check in
UserService.changePassword..gitignore: addedsecret.json/serviceAccount*.jsonso credential filescan't be committed by accident.
Config
New property, defaulted in code so existing environments keep working:
Testing
acmcss@pec.edu.inSMTP account; the emailwas delivered and contained
https://pecacm.in/forgot-password/change-password?token=<uuid>.www.pecacm.in, token preserved).single-use, 15-minute expiry, cross-user token rejected 401, unknown email 404,
blank password 400, password actually changes and the old one stops working.
Not in this PR
repository/auth.tsstill stubssendResetEmailandchangePassword— they return "This feature is still under testing" and nevercall the backend. The feature is not user-complete until that is implemented.
POST /v1/user/forgot-passwordstill requires ausernamequery param, but thefrontend reset page only has the token and the new password. Worth deciding
separately whether the backend should derive the user from the token.