Skip to content

Remove old-style function declaration. - #18

Merged
larsbrinkhoff merged 1 commit into
masterfrom
lars/c23
Aug 13, 2026
Merged

larsbrinkhoff merged 1 commit into
masterfrom
lars/c23

Conversation

@larsbrinkhoff

Copy link
Copy Markdown
Member

One more fix per @johnlorentzson.

Instead get the prototype declaration from itstar.h.
@EmanuelM153

Copy link
Copy Markdown

Hope its get merged soon 🙏. I cannot build PDP-10/its because itstar is failing to compile due to a conflicting type error caused by this line

Thanks in advance

@larsbrinkhoff
larsbrinkhoff merged commit b709cd8 into master Aug 13, 2026
@larsbrinkhoff
larsbrinkhoff deleted the lars/c23 branch August 13, 2026 04:19
@larsbrinkhoff

Copy link
Copy Markdown
Member Author

Merged now. Note that the "its" repository will need to update the submodule for the itstar change to take effect. But in the meanwhile, you can do the update locally.

@EmanuelM153

Copy link
Copy Markdown

Thanks! I hope it will also get updated soon too, because I also encounter this other error that has been fixed in itstar but hasn't been updated in the its submodule.

I really wish the submodule gets updated because I am currently packaging its under nix and that way it will be easier to publish and maintain in nixpkgs.

Thanks in advance

@larsbrinkhoff

Copy link
Copy Markdown
Member Author

I have submitted this. PDP-10/its#2398

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants