Remove old-style function declaration. - #18
Merged
Merged
Conversation
Instead get the prototype declaration from itstar.h.
|
Hope its get merged soon 🙏. I cannot build PDP-10/its because itstar is failing to compile due to a conflicting type error caused by this line Thanks in advance |
Member
Author
|
Merged now. Note that the "its" repository will need to update the submodule for the itstar change to take effect. But in the meanwhile, you can do the update locally. |
|
Thanks! I hope it will also get updated soon too, because I also encounter this other error that has been fixed in itstar but hasn't been updated in the its submodule. I really wish the submodule gets updated because I am currently packaging its under nix and that way it will be easier to publish and maintain in nixpkgs. Thanks in advance |
Member
Author
|
I have submitted this. PDP-10/its#2398 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One more fix per @johnlorentzson.