Skip to content

fix(pr-workflow): accept completed heads without review objects - #463

Merged
P4suta merged 2 commits into
mainfrom
fix/accept-reviewed-head-without-review-object
Oct 26, 2026
Merged

P4suta merged 2 commits into
mainfrom
fix/accept-reviewed-head-without-review-object

Conversation

@P4suta

@P4suta P4suta commented Oct 26, 2026

Copy link
Copy Markdown
Owner

Why

CodeRabbit can complete a clean draft review without submitting a review object for the current head.
Requiring that object blocks readiness after an unchanged rebase or an empty approval.

Changes

Accept a completed current-head status backed by the complete full review with the highest review ID on the same PR.
Require assessment path coverage, a canonical reviewed range, a complete comparison inventory, and a status created after the full review.
Accept only changes within the reviewed paths or an identical canonical PR diff.
Preserve repository review routing, owner pauses, unresolved findings, and rejection of incomplete evidence.
Add adapter regressions, pure decision checks, proof obligations, and the review evidence reference.
Cover carried completion under repository policy at every importance level, with no current-head review object or an empty approval.

Stacked on #459.

Closes #462.

@coderabbitai ignore

Validation

  • mise x -- just gen passed.
  • mise x -- just baselines --write --proof-counts refreshed the proof inventory counts.
  • mise x -- just check passed.
  • All 127 PR workflow integration tests passed.

Passing checks used an owned XDG_CACHE_HOME on macOS.
The inherited cache initially failed PowerShell startup with System.IO.FileLoadException.
The full Kani campaign and native Linux and Windows checks weren't run.

@P4suta
P4suta added this pull request to stack #460 October 26, 2026 08:07
@P4suta
P4suta force-pushed the fix/accept-reviewed-head-without-review-object branch from e87bdd1 to 1549de3 Compare October 26, 2026 12:03
Base automatically changed from feat/repository-pr-review to main October 26, 2026 12:04
@P4suta
P4suta force-pushed the fix/accept-reviewed-head-without-review-object branch from 1549de3 to 91bf8b3 Compare October 26, 2026 12:04
@P4suta
P4suta marked this pull request as ready for review October 26, 2026 12:04
@P4suta
P4suta merged commit cc4d8e4 into main Oct 26, 2026
6 checks passed
@P4suta
P4suta deleted the fix/accept-reviewed-head-without-review-object branch October 26, 2026 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(pr-workflow): accept completed heads without review objects

1 participant