Repository navigation
fix(assure): preserve existing findings across file renames - #446
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
assuretreats existing findings as new findings when a pull request moves source files because finding identities include paths.Changes
Use Git rename pairs to compare existing findings at their destination paths.
Keep each source survey at its actual paths so that ownership, catalog rules, and generated-file attributes still apply.
Preserve checks for new sites, extra occurrences, copies, touched findings, and lowered budgets.
Validation
The real Git regression reproduced the original failure before the implementation changed.
All 35 native
assureintegration tests pass on Windows, including five new real Git regression fixtures.Staged and committed renames keep existing findings.
New sites, repeated sites, and copies still fail.
Destination ownership and inherited merge parents have regression coverage.
Both parser and identity unit tests pass.
Formatting and strict Clippy checks pass for all dotfiles targets and features.
Native tests on macOS and Linux haven't run for the repair.
The existing pure finding-count and verdict rules remain unchanged.
The full proof campaign hasn't run.
Closes #445.
@coderabbitai ignore