Repository navigation
fix(pr-workflow): keep document edits available with open findings - #444
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
PR descriptions need to explain pending repairs and control the selected review route while findings remain open.
Document edits now remain available without marking the source complete.
Changes
Remove the finding-closure check from document authoring.
Keep authenticated source binding, signed assessment, issue, prose, pause, exclusion, and historical finding checks.
Final checks, readiness, and merge still reject unresolved current and outdated findings.
Validation
The new CLI regression fails on the original edit refusal and passes after the repair.
The regression checks both current and outdated findings, one document mutation, and continued rejection by final checks, readiness, and merge.
The existing outdated-finding regression and all ten review-policy unit tests pass.
Affected strict Clippy, scoped Rust formatting, and the whitespace check pass.
Native validation ran on Windows.
GitHub's source admission checks passed.
The hosted workflow reports the source and doesn't run native tests.
The full workspace suite and solver campaign remain unrun.
Closes #443.
@coderabbitai ignore