Repository navigation
fix(hooks): respect wrapper argument boundaries - #442
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The shell hook mistakes Clippy's
-D warningsfor a directory option of its outer Mise invocation.Normal dependency maintenance fails inspection before the compiler starts.
Changes
Separate each wrapper's own options from its child command and keep that boundary through nested wrappers.
Preserve script inspection, startup checks, directory uncertainty, non-executing queries, and ordinary Mise subcommands.
Keep unknown wrapper options blocked.
Call the same typed classifiers from production, finite specifications, and proof harnesses.
Give the existing read-only Tailscale fixture an explicit native execution directory.
Closes #441.
Validation
Strict workspace Clippy passed on Windows.
The dotfiles library passed 366 tests with four existing ignored tests.
The rules library passed all 393 tests.
The scoped Windows runtime installation succeeded, and the original strict Clippy command passed through the actual hook.
The complete workspace run stopped at
host_runtimeafter its isolated build exceeded the disk budget.Other workspace integration tests haven't completed.
The release inventory registers five new finite harnesses and seven new rejecting probes.
The solver campaign hasn't run.
Other host installations remain unverified.
@coderabbitai ignore