Repository navigation
Make model evaluation reproducible and compare model errors in the MAE table - #63
Merged
chanshing merged 3 commits intoOct 26, 2026
Merged
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
chanshing
marked this pull request as ready for review
October 26, 2026 18:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seeds all random number generators and enables deterministic PyTorch/cuDNN in the evaluation notebook so that repeated runs give the same results. Fixes the MAE table p-value, which tested the baseline's predictions against its own ground truth; it now runs a paired t-test on the per-participant errors of ActiNet against those of the baseline. The baseline random forest now uses sleep-transition handling in its HMM.
Breaking Changes
build_pvalue_cellparameters are renamed fromtrue_values/pred_valuestovalues1/values2. Callers that pass them by keyword must be updated. Positional calls and the return format are unchanged.build_mae_tablenow has a different meaning: it compares the two models' errors instead of testing the baseline's predictions against the ground truth. Values will differ from earlier runs.Files Changed
src/actinet/utils/eval_utils.pybuild_mae_table: the p-value is now a paired t-test between ActiNet's per-participant signed errors (true minus predicted) and the baseline'sbuild_pvalue_cell: parameters are now generic, two paired samples instead of true and predicted values; the test itself is unchangedEvaluateModel.ipynbPYTHONHASHSEEDand the cuBLAS workspace config, enablestorch.use_deterministic_algorithms, and disables cuDNN benchmarkinghmm_handle_sleep_transitionsenabledoutputs/actinet_vs_bbaapath