fix: parent-directory keys, exit sound, and upload overwrite prompt - #144
Merged
Merged
Conversation
Backspace and the usual parent-directory chords did nothing because the list key event never reported which key was pressed. Closing cut off the exit sound. Uploading always asked to replace a file that was not there.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
cargo test -p portkeydrop-core --lib -- local_files::cargo test -p portkeydrop --lib -- keys:: ids:: view:: file_pane::cargo clippy -p portkeydrop-core -p portkeydrop --all-targets -- -D warnings