Skip to content

Bundle Visual C++ runtime in Career 1.9 Windows snapshots - #184

Merged
Orinks merged 2 commits into
feat/career-1.9from
fix/windows-runtime-portable-20260906
Sep 6, 2026
Merged

Bundle Visual C++ runtime in Career 1.9 Windows snapshots#184
Orinks merged 2 commits into
feat/career-1.9from
fix/windows-runtime-portable-20260906

Conversation

@Orinks

@Orinks Orinks commented Sep 6, 2026

Copy link
Copy Markdown
Owner

What changed and why

Windows snapshots could fail to start with missing Visual C++ runtime DLLs. Stage the complete official x64 CRT family beside the executable and audit normal and delay-loaded VC dependencies before packaging. Target Career 1.9 as explicitly requested by the owner.

Preserve the synchronized snapshot workflow unchanged to avoid its main/Career equality guard blocking nightly builds. Add a separate Windows runtime packaging workflow for Career PRs and relevant pushes.

What players or maintainers will notice

Portable Windows downloads include the runtime DLLs needed to start without a separate redistributable installer. Incomplete or wrong-architecture runtime sources fail packaging.

Tests and checks run

  • Full Python tooling suite rerun on final content: 305 passed, 10 skipped.
  • Focused runtime packaging regressions: 13 passed locally and on Windows CI.
  • Windows CI staged and audited the actual installed Visual Studio CRT successfully: https://github.com/Orinks/Freight-Fate/actions/runs/34066695564
  • Ruff, Python compilation, diff whitespace checks passed; local merge tree matches the tested tree exactly.
  • Independent code review found no remaining blockers after correcting the snapshot workflow synchronization issue.
  • Clean Windows machine game launch, sound, and screen-reader validation remain release follow-up work recorded in ROADMAP.md; hosted-runner CRT validation does not establish that.

Accessibility impact

Packaging-only change; no gameplay or spoken interface changes. Prevents startup failures before screen-reader support can initialize.

Changelog

  • Added player-facing changelog entry and updated Career 1.9 roadmap.

@Orinks
Orinks merged commit 0cec9c2 into feat/career-1.9 Sep 6, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant