Bundle Visual C++ runtime in Career 1.9 Windows snapshots - #184
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed and why
Windows snapshots could fail to start with missing Visual C++ runtime DLLs. Stage the complete official x64 CRT family beside the executable and audit normal and delay-loaded VC dependencies before packaging. Target Career 1.9 as explicitly requested by the owner.
Preserve the synchronized snapshot workflow unchanged to avoid its main/Career equality guard blocking nightly builds. Add a separate Windows runtime packaging workflow for Career PRs and relevant pushes.
What players or maintainers will notice
Portable Windows downloads include the runtime DLLs needed to start without a separate redistributable installer. Incomplete or wrong-architecture runtime sources fail packaging.
Tests and checks run
Accessibility impact
Packaging-only change; no gameplay or spoken interface changes. Prevents startup failures before screen-reader support can initialize.
Changelog