Skip to content

Address Make app review feedback - #5

Merged
JhumanJ merged 1 commit into
mainfrom
codex/make-appbot-feedback
Jul 29, 2026
Merged

Address Make app review feedback#5
JhumanJ merged 1 commit into
mainfrom
codex/make-appbot-feedback

Conversation

@JhumanJ

@JhumanJ JhumanJ commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Summary

  • make the self-hosted base URL immutable and document required token abilities
  • cap the forms RPC at 300 results and return an explicit JSON webhook acknowledgement
  • align labels, connection metadata, and connection errors with Make guidelines
  • add contract coverage for every changed review requirement

Review findings validated separately

  • integration_id: make is intentional and accepted by OpnForm's registered MakeIntegration handler
  • the handler emits form_id, form_title, form_slug, submission_id, optional edit_link, and data
  • trigger mappable parameters remain empty; workspace/form selectors live only on the webhook

Validation

  • npm test (10/10 passed)
  • JSON parse check for all tracked JSON files
  • git diff --check

@JhumanJ
JhumanJ merged commit 8aabf58 into main Jul 29, 2026
1 check passed
@JhumanJ
JhumanJ deleted the codex/make-appbot-feedback branch July 29, 2026 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant