Repository navigation
build(sim, deployer): bump dep in deployer - #236
Open
andrew-fleming wants to merge 4 commits into
Open
andrew-fleming wants to merge 4 commits into
andrew-fleming wants to merge 4 commits into
Conversation
OpenZeppelin AI AuditorWarning Review skipped for commit ℹ️ Review info
|
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
midnight-js 5.0.0 builds calls the node refuses -> (one of a few examples) https://github.com/OpenZeppelin/compact-contracts/actions/runs/44470777863/job/135392513861
Since the deps are patches, this PR proposes to mark them under the
Changedheader meaning that a release should be a patch. If it's insisted that the release that includes this PR's changes is a minor bump, the CLI needs to be re-released thereafterThere are still some issues with memory on the NST. Since the compact bump to 0.36.0,
burnandburnFromSelfare k=18 circuits with 544 MB prover keys. The proof server keeps every key it loads, so memory climbs with each new large circuit a leg proves. We'll likely have to prove fewer large circuits per proof-server session, but that's a contracts lib problem and out of scope here