Skip to content

build(sim, deployer): bump dep in deployer - #236

Open
andrew-fleming wants to merge 4 commits into
OpenZeppelin:mainfrom
andrew-fleming:bump-dep-in-deployer
Open

andrew-fleming wants to merge 4 commits into
OpenZeppelin:mainfrom
andrew-fleming:bump-dep-in-deployer

Conversation

@andrew-fleming

Copy link
Copy Markdown
Contributor

midnight-js 5.0.0 builds calls the node refuses -> (one of a few examples) https://github.com/OpenZeppelin/compact-contracts/actions/runs/44470777863/job/135392513861

Since the deps are patches, this PR proposes to mark them under the Changed header meaning that a release should be a patch. If it's insisted that the release that includes this PR's changes is a minor bump, the CLI needs to be re-released thereafter


There are still some issues with memory on the NST. Since the compact bump to 0.36.0, burn and burnFromSelf are k=18 circuits with 544 MB prover keys. The proof server keeps every key it loads, so memory climbs with each new large circuit a leg proves. We'll likely have to prove fewer large circuits per proof-server session, but that's a contracts lib problem and out of scope here

@andrew-fleming
andrew-fleming requested review from a team as code owners November 19, 2026 21:15
@openzeppelin-ai-auditor

Copy link
Copy Markdown

OpenZeppelin AI Auditor

Warning

Review skipped for commit d7ef4a0: Pull requests from forks are not supported yet.

ℹ️ Review info
  • Project: Compact Tools
  • Commit: d7ef4a0 (base 41362dc on main)
  • Changed lines: 592 across 6 files
  • Trigger: pull request opened

@coderabbitai

coderabbitai Bot commented Nov 19, 2026 •

Copy link
Copy Markdown

Important

  • Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: cb51ae48-1819-474e-b08b-75b5dbc62c6a
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant