Repository navigation
L-01: Document that consumption operations and the owner unlock must … - #130
Open
haseebrabbani wants to merge 1 commit into
Open
haseebrabbani wants to merge 1 commit into
haseebrabbani wants to merge 1 commit into
Conversation
haseebrabbani
requested review from
0xNeshi,
ericnordelo,
igingu and
pepebndc
as code owners
November 19, 2026 07:55
0xNeshi
force-pushed
the
audit-m1-02-l05
branch
from
November 19, 2026 10:37
20f5b0c to
56d7cac
Compare
0xNeshi
force-pushed
the
audit-m1-02-l01
branch
from
November 19, 2026 10:45
9cbd78f to
3d63a64
Compare
…archive the holding The workflows credit the view a consumption operation returns and create new holdings from it, and `holdingOwnerUnlockImpl` creates the unlocked replacement without archiving the locked holding. Neither can check that the holding left the ledger, since fetching an archived contract aborts. State both laws in the `HoldingOps` doc comment, the module's trust boundary, `holdingOwnerUnlockImpl`, `debitHoldings`, and the `token-cip112-utils` README trust boundary: each consumption operation must archive the holding it receives with a template-typed archive or a consuming choice, and the owner-unlock choice must be consuming. Breaking either creates tokens on transfers, allocations, settlements, returns and owner unlocks, counts an input id repeated in one call once per occurrence, and leaves a burn destroying nothing.
0xNeshi
force-pushed
the
audit-m1-02-l01
branch
from
November 19, 2026 13:17
3d63a64 to
b783107
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #86 (L-01). Stacked on #116, base
audit-m1-02-l05.Docs only. The workflows credit the view a consumption operation returns, and
holdingOwnerUnlockImplnever archivesself. Neither can check that a holding left the ledger, because fetching an archived contract aborts.HoldingOpsdoc and module trust boundary:fundHolding,deliverHoldingandreturnHoldingmust each archive the holding they receive, with a template-typedarchiveor a consuming choice, and the owner-unlock choice must be consuming. Breaking either creates tokens on transfers, allocations, settlements, returns and owner unlocks, counts a repeated input id once per occurrence, and makes a burn destroy nothing.holdingOwnerUnlockImplanddebitHoldingspoint at the law.token-cip112-utilsREADME trust boundary lists the same two requirements.Live-checked on a wall-clock sandbox: a compliant consumer keeps supply unchanged on every path, and a non-archiving operation or a nonconsuming unlock creates tokens. No CHANGELOG entry, since this is documentation only.