Skip to content

L-11: Bind the admin in the custom example with a co-signing pauser - #125

Open
haseebrabbani wants to merge 1 commit into
audit-m1-02-l05from
audit-m1-02-l11
Open

haseebrabbani wants to merge 1 commit into
audit-m1-02-l05from
audit-m1-02-l11

Conversation

@haseebrabbani

Copy link
Copy Markdown
Collaborator

Closes #95. Stacked on #116 (L-05); base audit-m1-02-l05.

Changes

  • Custom example: pauser moves into AppRoles and co-signs MyRules, MyHolding, MyTransferInstruction and MyAllocation; MyHolding_Spend also needs it. The admin alone can no longer create a rules contract, mint or copy a holding, or spend one outside the workflows.
  • Beyond the issue: co-signing alone is not enough, because the admin picks the pauser field and can sign a whole registry naming itself. myOps (fund, deliver, return), pinMyAllocation and MyRules_ExpireTransferInstructions now refuse contracts naming a different pauser. Without this, such a registry's holding funds a real transfer and its allocation covers a real settlement leg (shown by mutation).
  • Docs: HoldingOps, TokenRules and the utils trust boundary state that roles and policy on a rules contract restrict wallets only. The integration guide calls one TokenRules per configuration operator practice. The custom README adds "Binding the admin" with privacy, liveness, coordination and independence costs. No CHANGELOG entry (example and doc comments only).

Notes

The pauser moves into AppRoles and co-signs MyRules, MyHolding,
MyTransferInstruction and MyAllocation; MyHolding_Spend needs its authority
too. The admin alone can no longer create a second rules contract, mint or
copy a holding, or spend one outside the workflows.

Co-signing alone does not close the gap, because the admin chooses the
pauser field: it can sign every template naming a pauser it controls. The
consumption operations, the allocation pin and the instruction expiry
therefore refuse a contract that names a different pauser, so such a
registry is a separate token.

Document that roles and policy on a rules contract restrict wallets only
(HoldingOps, TokenRules, the utils trust boundary), that one TokenRules per
configuration is operator practice, and the co-signing pauser's privacy,
liveness, coordination and independence costs.

Closes #95
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[M1: Audit 2: L-11]: Bind the admin in the custom example and document that roles on a rules contract do not bind the admin

1 participant