fix(ocr): resolve custom ship aliases in GUI fleet selection - #533
Open
ShiinaKuroko wants to merge 1 commit into
Open
fix(ocr): resolve custom ship aliases in GUI fleet selection#533ShiinaKuroko wants to merge 1 commit into
ShiinaKuroko wants to merge 1 commit into
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
ShiinaKuroko
force-pushed
the
fix/ship-alias-search
branch
from
August 5, 2026 03:45
4dc2270 to
86f35ce
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
This is a follow-up fix for the OCR-enhanced fleet selection path introduced in #521.
The issue is triggered by the GUI weekly-task / fleet-preset path:
85??) when no explicit customsearch_nameis present????: 85??)85??filters out the actual????entry and OCR receives no matching shipFix
This remains a backend fallback because the GUI execution path depends on the backend alias registry loaded from
ocr.ship_name_aliases. No GUI code is changed.Tests
python -m pytest -q(764 passed)pre-commit run --files autowsgr/vision/ocr_rules.py autowsgr/ui/choose_ship_page.py testing/ui/test_choose_ship_page.py