Skip to content

Compare facterversion against installed facter in acceptance test #597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
silug wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Compare facterversion against installed facter in acceptance test #597

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions packaging/acceptance/tests/ensure_puppet_facts_can_use_facter.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,14 @@

agents.each do |agent|
step 'test puppet facts with correct facter version' do
# Compare against the installed facter rather than a hardcoded major
# version, which broke on every openfact major bump (4 -> 5 -> 6).
installed_version = on(agent, facter('--version'), :acceptable_exit_codes => [0]).stdout.strip
on(agent, puppet('facts'), :acceptable_exit_codes => [0]) do |result|
facter_major_version = Integer(JSON.parse(result.stdout)["facterversion"].split('.').first)
assert(5 >= facter_major_version, "wrong facter version")
facterversion = JSON.parse(result.stdout)["facterversion"]
assert_equal(installed_version, facterversion,
"puppet facts reported facterversion #{facterversion.inspect}, " \
"but the installed facter is #{installed_version.inspect}")
end
end

Expand Down