Skip to content

Use dedicated logging for interpose and development warnings#855

Merged
Kyle-Ye merged 4 commits intomainfrom
codex/interpose-log-object
Apr 28, 2026
Merged

Use dedicated logging for interpose and development warnings#855
Kyle-Ye merged 4 commits intomainfrom
codex/interpose-log-object

Conversation

@Kyle-Ye
Copy link
Copy Markdown
Collaborator

@Kyle-Ye Kyle-Ye commented Apr 27, 2026

Summary

  • Add a dedicated Interpose OSLog in Interpose.c and route interpose diagnostics through it instead of OS_LOG_DEFAULT.
  • Remove the inline [OpenSwiftUI] text prefix from those interpose log messages now that the subsystem/category carry the context.
  • Replace development-only print diagnostics in Logging.swift with a DEBUG-only development logger.
  • Update resolved DarwinPrivateFrameworks pins to the merged 2024 default-release fix.

Why

The interpose logs should be filterable through a dedicated category rather than mixed into the default log stream. Development diagnostics should also use the logging system instead of printing directly.

Validation

  • xcrun clang -fsyntax-only -fblocks -std=c11 -I Sources/OpenSwiftUI_SPI -D_OPENSWIFTUI_SWIFTUI_RENDER=1 Sources/OpenSwiftUI_SPI/Util/Interpose.c
  • DARWINPRIVATEFRAMEWORKS_TARGET_RELEASE=2024 swift build --target OpenSwiftUI_SPI
  • DARWINPRIVATEFRAMEWORKS_TARGET_RELEASE=2024 swift build --target OpenSwiftUICore
  • DARWINPRIVATEFRAMEWORKS_TARGET_RELEASE=2024 swift build -c release --target OpenSwiftUICore

@Kyle-Ye Kyle-Ye changed the title [codex] Use dedicated logging for interpose and development warnings Use dedicated logging for interpose and development warnings Apr 27, 2026
@Kyle-Ye Kyle-Ye marked this pull request as ready for review April 27, 2026 17:32
@augmentcode
Copy link
Copy Markdown

augmentcode Bot commented Apr 27, 2026

🤖 Augment PR Summary

Summary: This PR refines diagnostics by routing interpose and development-only warnings through dedicated OSLog categories.

Changes:

  • Added a dedicated Interpose OSLog in Interpose.c and moved interpose diagnostics off OS_LOG_DEFAULT
  • Removed the inline [OpenSwiftUI] prefix from interpose messages since subsystem/category now provide context
  • Replaced development-only print-based unimplemented warnings in Logging.swift with a DEBUG-only Log.development logger
  • Updated DarwinPrivateFrameworks pinned revision in Package.resolved

Technical Notes: Keeps diagnostics filterable via subsystem/category, while avoiding noisy stdout output outside of DEBUG builds.

🤖 Was this summary useful? React with 👍 or 👎

Copy link
Copy Markdown

@augmentcode augmentcode Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. No suggestions at this time.

Comment augment review to trigger a new review at any time.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 27.20%. Comparing base (4330121) to head (915c890).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #855      +/-   ##
==========================================
- Coverage   27.20%   27.20%   -0.01%     
==========================================
  Files         673      673              
  Lines       44165    44165              
==========================================
- Hits        12016    12013       -3     
- Misses      32149    32152       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Kyle-Ye Kyle-Ye merged commit 51da570 into main Apr 28, 2026
8 of 15 checks passed
@Kyle-Ye Kyle-Ye deleted the codex/interpose-log-object branch April 28, 2026 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant