Improve view distance and water behavior

[MichaelFisher1997]

Summary

• increase default and high render distances while reducing wasted shadow/MSAA work
• align chunk streaming/fog with longer-distance rendering and cap far foliage cutouts
• remove water emissive glow and document/test Luanti-like falling-flow behavior

Verification

• bun run typecheck
• bun run test
• bun run build
• website: bun run typecheck
• website: bun run build

[railway-app]

🚅 Deployed to the voxl-pr-13 environment in voxl

Service	Status	Web	Updated (UTC)
website	✅ Success (View Logs)	Web	Jun 18, 2026 at 2:15 am
game	✅ Success (View Logs)	Web	Jun 18, 2026 at 2:14 am

[github-actions]

📋 Summary

No linked issues (e.g., "Fixes #…", "Closes #…") are mentioned in the PR body.

The PR extends default/high render distances (up to 20 chunks), tightens fog to the chunk radius, caps far-foliage cutouts, removes water emissive glow, and optimizes the liquid update queue. It also adds passing tests for Luanti-like falling-flow behavior. However, it bundles unrelated Railway infrastructure-as-code files and a new railway devDependency, which is outside the stated PR scope. Builds and tests all pass.

📌 Review Metadata

• Reviewed Commit SHA: a7e756b0daeb1d561716832e276edd8ae1c949dd
• Reviewed PR: Improve view distance and water behavior #13

🔴 Critical Issues (Must Fix - Blocks Merge)

None identified.

⚠️ High Priority Issues (Should Fix)

[HIGH] .railway/railway.ts, .railway/README.md, .agents/skills/railway-config/SKILL.md, package.json:25, bun.lock — Railway infrastructure config bundled into a graphics/water PR
Confidence: High
Description: The PR title and body describe only view-distance and water-behavior changes, yet roughly one-quarter of the diff adds Railway deployment config plus a new railway devDependency (pulling in tsx, esbuild, graphql, etc.). This conflates two unrelated concerns, expands the lockfile, and complicates rollback/review.
Impact: Scope creep; deployment infrastructure is reviewed inside a feature PR; larger install footprint.
Suggested Fix: Split the Railway config, README, skill file, and railway dependency into a separate PR. Keep this PR focused on the game changes.

💡 Medium Priority Issues (Nice to Fix)

[MEDIUM] src/game/graphics/GraphicsController.ts:136-138 — Comment falsely claims engine-level MSAA is still active
Confidence: High
Description: src/engine/Renderer.ts:19 now creates the WebGL context with antialias: false, so engine-level MSAA is disabled. The comment here still says "Engine-level MSAA (set at context creation) remains as the baseline edge AA."
Impact: Misleading documentation; future maintainers may incorrectly assume MSAA is always available.
Suggested Fix: Update the comment to match the new context:

// AA off → tear down the pipeline so the scene renders straight to the
// default framebuffer (no fullscreen pass). Engine-level antialias is also
// disabled at context creation; low/custom presets render with no AA.
this.pipeline.dispose();
this.pipeline = null;

ℹ️ Low Priority Suggestions (Optional)

None identified.

📊 SOLID Principles Score

Principle	Score	Notes
Single Responsibility	6	Core changes are focused, but Railway infra is unrelated to view/water work
Open/Closed	7	Extends graphics/liquid systems without invasive core edits
Liskov Substitution	8	No inheritance changes
Interface Segregation	8	Migration helpers are small and focused
Dependency Inversion	7	New railway is dev-only; game runtime unaffected
Average	7.2

🎯 Final Assessment

Overall Confidence Score: 75%

• Code Quality: 80% (well-structured, but one stale comment and scope creep)
• Completeness: 85% (game changes fulfill the PR description; Railway additions are undocumented in the PR body)
• Risk Level: 60% (higher max view distance and disabled MSAA may affect low-end visuals/perf)
• Test Coverage: 80% (liquid tests added; no tests for graphics migration/fog math)

Merge Readiness:

• All critical issues resolved
• SOLID average score >= 6.0
• Overall confidence >= 60%
• No security concerns
• Tests present and passing

Verdict:

MERGE WITH FIXES — split Railway infrastructure into its own PR and update the stale MSAA comment before merging.

opencode session  |  github run

[github-actions]

📋 Summary

No linked issues (e.g., "Fixes #…", "Closes #…") are mentioned in the PR body.

The PR increases default/high render distances (up to 20 chunks), disables engine-level MSAA and shadows in presets, caps foliage cutout distance, tightens fog to the chunk radius, removes water emissive glow, optimizes the liquid update queue with a head/compaction scheme, and adds tests for Luanti-like falling-flow behavior. The author has cleaned up the previously reported scope creep (Railway infrastructure is no longer part of the diff). Builds and tests all pass.

📌 Review Metadata

• Reviewed Commit SHA: dc3adfb1072eeff3f2fbb37a16b2dc2dd8adeb2a
• Reviewed PR: Improve view distance and water behavior #13

🔴 Critical Issues (Must Fix - Blocks Merge)

None identified.

⚠️ High Priority Issues (Should Fix)

None identified.

💡 Medium Priority Issues (Nice to Fix)

None identified.

ℹ️ Low Priority Suggestions (Optional)

None identified.

✅ Previous Issue Verification

• ✅ [FIXED] Previous issue: Railway infrastructure config bundled into the graphics/water PR — .railway/, .agents/skills/railway-config/, railway dependency, and related lockfile changes are no longer present in the diff.
• ✅ [FIXED] Previous issue: Stale MSAA comment in src/game/graphics/GraphicsController.ts — the comment now correctly states that engine-level antialiasing is disabled at context creation.

📊 SOLID Principles Score

Principle	Score	Notes
Single Responsibility	9	Changes are tightly focused on view distance, fog, foliage, shadows/MSAA, and water behavior
Open/Closed	8	Extends graphics/liquid systems without invasive core edits
Liskov Substitution	8	No inheritance changes
Interface Segregation	9	Queue compaction and settings migration helpers are small and focused
Dependency Inversion	8	No new runtime dependencies; settings migration remains data-driven
Average	8.4

🎯 Final Assessment

Overall Confidence Score: 92%

• Code Quality: 90% (clean, focused, previous review feedback addressed)
• Completeness: 95% (PR description fully implemented and verified)
• Risk Level: 85% (higher max view distance may stress low-end devices, but defaults remain conservative)
• Test Coverage: 95% (liquid behavior tests added and passing)

Merge Readiness:

• All critical issues resolved
• SOLID average score >= 6.0
• Overall confidence >= 60%
• No security concerns
• Tests present and passing

Verdict:

MERGE — all prior issues were addressed, the diff is now scope-focused, and game/website builds and tests pass.

opencode session  |  github run