feat: publish media file type lifecycle events to sponsor services#492
Open
feat: publish media file type lifecycle events to sponsor services#492
Conversation
Signed-off-by: romanetar <roman_ag@hotmail.com>
smarcet
reviewed
Apr 9, 2026
| { | ||
| private int $id; | ||
| private string $name; | ||
| private string $description; |
Collaborator
There was a problem hiding this comment.
@romanetar
@romanetar Nullable fields passed to non-nullable DTO constructor ( runtime TypeError )
SummitMediaFileType::getDescription() returns ?string and getAllowedExtensions() returns ?string, but SummitMediaFileTypeCreatedEventDTO::__construct declares both as string.
smarcet
reviewed
Apr 9, 2026
| return new self( | ||
| $summit_media_file_type->getId(), | ||
| $summit_media_file_type->getName(), | ||
| $summit_media_file_type->getDescription(), |
Collaborator
There was a problem hiding this comment.
smarcet
reviewed
Apr 9, 2026
| return SummitMediaFileTypeFactory::populate($type, $payload); | ||
| $media_file_type = SummitMediaFileTypeFactory::populate($type, $payload); | ||
|
|
||
| PublishSponsorServiceDomainEventsJob::dispatch( |
Collaborator
There was a problem hiding this comment.
@romanetar @romanetar Update event dispatched inside transaction ( fires even on rollback) move out side ( same pattern as add )
smarcet
reviewed
Apr 9, 2026
|
|
||
| $this->repository->delete($type); | ||
|
|
||
| PublishSponsorServiceDomainEventsJob::dispatch( |
Collaborator
There was a problem hiding this comment.
smarcet
requested changes
Apr 9, 2026
Collaborator
smarcet
left a comment
smarcet
left a comment
There was a problem hiding this comment.
@romanetar please review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref https://app.clickup.com/t/86b79912c