Skip to content

Describe model types#529

Merged
max-rosin merged 2 commits intomigrationfrom
517_describe_model_types
Jul 7, 2021
Merged

Describe model types#529
max-rosin merged 2 commits intomigrationfrom
517_describe_model_types

Conversation

@max-rosin
Copy link
Copy Markdown
Contributor

@max-rosin max-rosin commented Jun 17, 2021 •
edited
Loading

This PR resolves #517

Fills the topics:

  • environmental_effect_model.adoc
  • logical_model.adoc
  • sensor_model.adoc
  • traffic_participant.adoc

vehicle_dynamics.adoc was excluded for now for lack of content.

  • I have done the DCO signoff.
  • My changes generate no errors when passing CI tests.
  • I have successfully implemented and tested my fix/feature locally.
  • Appropriate reviewer(s) are assigned.

@max-rosin
feat(docs): Describe model types (#517)
0c82cf3 
Signed-off-by: Maximilian Rosin <maximilian.rosin@parson-europe.com>
@max-rosin max-rosin self-assigned this Jun 17, 2021
@stefancyliax stefancyliax added the Documentation Everything which impacts the quality of the documentation and guidelines. label Jun 23, 2021
@stefancyliax stefancyliax added this to the V3.4.0 milestone Jun 23, 2021
@max-rosin max-rosin added the ReadyForCCBReview Indicates that this PR is ready for a final review and merge by the CCB. label Jun 24, 2021
@max-rosin
fix(docs): Fix typos (#517)
8a14884 
Signed-off-by: Maximilian Rosin <maximilian.rosin@parson-europe.com>
ThomasNaderBMW
ThomasNaderBMW reviewed Jul 7, 2021
View reviewed changes
Comment thread doc/architecture/environmental_effect_model.adoc
@max-rosin max-rosin merged commit 922755b into migration Jul 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ThomasNaderBMW ThomasNaderBMW ThomasNaderBMW left review comments

@clemenshabedank clemenshabedank Awaiting requested review from clemenshabedank

@HendrikAmelunxen HendrikAmelunxen Awaiting requested review from HendrikAmelunxen

@kmeids kmeids Awaiting requested review from kmeids

@Krishna626 Krishna626 Awaiting requested review from Krishna626

@PhRosenberger PhRosenberger Awaiting requested review from PhRosenberger

@pmai pmai Awaiting requested review from pmai

@stefancyliax stefancyliax Awaiting requested review from stefancyliax

@0815-code 0815-code Awaiting requested review from 0815-code

Assignees

@max-rosin max-rosin

Labels

Documentation Everything which impacts the quality of the documentation and guidelines. ReadyForCCBReview Indicates that this PR is ready for a final review and merge by the CCB.

Projects

None yet

Milestone

V3.4.0

Development

Successfully merging this pull request may close these issues.

3 participants

@max-rosin @ThomasNaderBMW @stefancyliax