ui: identify password columns by field type, add password Cell - #1016
Merged
Conversation
- Default column derivation in ListViewClient, standalone ListTable, and deriveItemView's Relationship-table columns now excludes a password column by field type instead of matching the field name "password". - Register a password Cell in the cell registry that renders a fixed mask regardless of value, so an explicitly-shown password column no longer depends on HashedPassword.toJSON() redaction for safety. - Remove the dead, uncalled getFieldDisplayValue export. Closes #982
🦋 Changeset detectedLatest commit: aa6c6c6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 9 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Deployment failed for project stack-docs with the following error: Learn More: https://vercel.com/open-saas?upgradeToPro=build-rate-limit |
Member
Author
Code reviewRan a full review pass (line-by-line diff, removed-behavior audit, cross-file tracing, reuse/simplification/efficiency/altitude, CLAUDE.md conventions). Findings: none.
Generated by Claude Code |
Member
Author
|
The Generated by Claude Code |
Contributor
Coverage Report for Core Package Coverage (./packages/core)
File CoverageNo changed files found. |
Contributor
Coverage Report for UI Package Coverage (./packages/ui)
File Coverage
|
||||||||||||||||||||||||||||||||||||||
Contributor
Coverage Report for CLI Package Coverage (./packages/cli)
File CoverageNo changed files found. |
Contributor
Coverage Report for Auth Package Coverage (./packages/auth)
File CoverageNo changed files found. |
Contributor
Coverage Report for Storage Package Coverage (./packages/storage)
File CoverageNo changed files found. |
Contributor
Coverage Report for RAG Package Coverage (./packages/rag)
File CoverageNo changed files found. |
Contributor
Coverage Report for Storage S3 Package Coverage (./packages/storage-s3)
File CoverageNo changed files found. |
Contributor
Coverage Report for Storage Vercel Package Coverage (./packages/storage-vercel)
File CoverageNo changed files found. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
"password", in all three places that curated default columns:ListViewClient(main list view), the standaloneListTable, andderiveItemView's Relationship-table column derivation. A field declaredsecret: password()is now excluded from default columns; a field merely namedpasswordthat isn'tpassword()-typed (e.g.password: text()) is no longer excluded.passwordCell in the cell registry (cellComponentRegistry) that renders a fixed••••••••mask, ignoring the value entirely. A password-typed column shown deliberately via an explicitcolumnsprop now renders the mask instead of falling through to the default text Cell (previously[object Object], saved only incidentally byHashedPassword.toJSON()redaction).getFieldDisplayValueexport from@opensaas/stack-ui— it had zero callers in the actual rendering path (Cells render each field type directly) and disagreed with what was actually rendered.Test plan
ListViewClient,ListTable,deriveItemView), a field merely namedpasswordis not excluded when it isn't password-typed, and the newPasswordCell(direct render + viaCellRenderertype resolution) renders a fixed mask ignoring the raw value.pnpm testinpackages/ui— 594/594 passingpnpm buildinpackages/ui(typecheck viatsc) — passespnpm lint— no new warnings/errorspnpm manypkg fix/pnpm format— cleanCloses #982
Generated by Claude Code