Repository navigation
Conversation
When running `oscap`, if the `--verbose-log-file` points to a directory that does not exist, `oscap` runs, does nothing, and exits with 0 indicating no error. No error gets printed to the shell. The reason is incorrect handling of return value of `oscap_set_verbose` in `oscap_module_process` in `utils/oscap-tool.c`. Moreover, the error messages use the `oscap_seterr` doesn’t print anything because the error stack isn't printed on the failure path. With this change, OpenSCAP will print an error message and terminate with 1 if a non-existing directory path is provided in the `--verbose-log-file` option. Resolves: https://redhat.atlassian.net/browse/RHEL-295815
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running
oscap, if the--verbose-log-filepoints to a directory that does not exist,oscapruns, does nothing, and exits with 0 indicating no error. No error gets printed to the shell. The reason is incorrect handling of return value ofoscap_set_verboseinoscap_module_processinutils/oscap-tool.c. Moreover, the error messages use theoscap_seterrdoesn’t print anything because the error stack isn't printed on the failure path.With this change, OpenSCAP will print an error message and terminate with 1 if a non-existing directory path is provided in the
--verbose-log-fileoption.Resolves: https://redhat.atlassian.net/browse/RHEL-295815