Repository navigation
feat(frontbin): match 29 functions and fix native source selection - #2
Merged
Merged
Conversation
Exclude native NTSC-U rows without a PAL counterpart from the PAL object fallback, preventing an invalid address conversion. Validation: python3 tests/check_repository.py passed; python3 -m unittest discover -s tests passed all 24 tests.
Integrate six shared functions in 382380.c using file-wide @ps2as settings and four native NTSC-U implementations. Update version maps, build records and progress reports; remove promoted drafts and preserve the unmatched 003B0C70 attempt. Validation: all three PAL core outputs match retail; the NTSC-U C-linked build matches all 54 targets. Repository checks and all 24 unit tests pass; staged whitespace checks pass.
Integrate shared implementations adapted from the NTSC decomp drafts (GPL-3.0), using existing file flags. Preserve required symbol-size hints and fixed-address global accesses. Retire 20 integrated drafts, retain four documented unfinished attempts, and refresh declarations and progress records. Verification: tools/build.py --version pal --target all reported three MATCH results; tools/asm_build.py --version us --c reported 54/54 targets matching. All 20 integrations are selected from C. tools/version_map.py --check, tests/check_repository.py, and all 24 unit tests passed.
Resolve the equivalent native function implementations, combine native compiler flags, and regenerate progress records while preserving upstream native-object support. Verified: three PAL programs MATCH; all 54 NTSC-U targets MATCH; 37 expected functions selected from C; repository checks and all 36 unit tests passed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add 26 shared PAL/NTSC-U frontbin implementations and three NTSC-U-only
implementations, adapted from the NTSC decomp drafts under GPL-3.0.
Preserve existing file compiler flags, required file-scope symbol-size
hints, and fixed-address global accesses. Fix native C exclusion from
the PAL object fallback. Retire integrated drafts, document four
unfinished attempts, and refresh declarations and progress records.
Merged current master and verified: