Repository navigation
Match five HUD and level initialization functions - #417
Merged
Merged
Conversation
Add five qualified C implementations: the centered text draws func_002CDA20, func_002CF2B8 and func_002D53F0; Maktar group accumulation func_L02_003FB000; and shared player initialization func_L22_002A8B98. Together they replace 876 distinct USA v1.01 code bytes at 92 carrying placements across the three releases. Keep the formatter style 64 bits and use the actual signed32 text-address getter and integer-returning initialization interfaces. Real formatter calls and the final Maktar report-state store use nonempty one-pass groups, as in current active RAC1 game C. Ordinary assignments suffice for the player initializer. Document the measured source precedent and reconcile the older blocker entry. Remove superseded matching drafts and four functional-backfill entries. Retain the unsuccessful node-list, object-state and vector-grid findings, including the remaining allocation and borrowed-layout constraints. Validation: all 84 strict linked programs equal retail, with no C fallback; all 92 intended C placements verified in placed.json; 382 unit tests; repository checks; progress --check for US, US2 and PAL. Production source inputs remained unchanged throughout qualification. Progress report and README bytes are unchanged. Matching verifies the PS2 images; native-port runtime behavior remains separate.
ByteMatch progress reportSCUS_972.68_v2
No function changes. SCES_516.07
No function changes. SCUS_972.68
No function changes. Commit b887d97 · Ratchet & Clank: Going Commando on ByteMatch |
bigbeno37
added a commit
that referenced
this pull request
Nov 5, 2026
tools/build.py all --strict on master 236cfdf (after #416, #417, #418, #420, 4b786ab, 4d6e47b and 236cfdf): 28 programs OK in each of us, pal and us2. tools/progress.py for each release; --check --strict passes for all three. US 8,173 of 8,584 (91.80%), PAL 7,242 of 8,677 (56.58%), US2 7,932 of 8,639 (86.02%). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add five C implementations (876 distinct USA v1.01 bytes):
func_002CDA20func_002CF2B8func_002D53F0func_L02_003FB000func_L22_002A8B98The text getter keeps its actual signed32 EE address return, the formatter keeps its integer return and 64-bit style, and the initializer calls the real integer-returning subsystem interface.
The text draws group their actual formatter calls; Maktar groups its final report-state store. These nonempty one-pass statement groups follow current active RAC1 game C: mission-field read, inner cache loop. The existing compiler notes and blocker entry now record that precedent and its limits. Ordinary assignments suffice for the player initializer.
Remove the superseded matching drafts and four functional-backfill entries. Keep the unsuccessful node-list, object-state and vector-grid findings with their remaining allocation/layout constraints.
Validation on
b887d976:tools/build.py all --strict --jobs 6for US, US2 and PAL: 84/84 programs equal retail; zero C fallbacks.placed.jsonfiles. Canonical identity absences are recorded separately, without credit.tools/progress.py --checkfor all three releases pass.PS2 byte equality is verified; native-port runtime behavior remains a separate check. The first ten functions from #416 are excluded from this five-function count.