Conversation
✅ Deploy Preview for openpodcastapi ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
My European heart says: we should recommend using 24hr notation instead :P
| @@ -0,0 +1,9 @@ | |||
| extends: existence | |||
| message: "Use 'July 31, 2016' format, not '%s'." | |||
There was a problem hiding this comment.
Is there a European variant of this? (31 July 2016) :P
There was a problem hiding this comment.
@keunes We can override it if needs be. I would always just use 2016-07-31 myself.
| @@ -0,0 +1,29 @@ | |||
| extends: capitalization | |||
| message: "'%s' should use sentence-style capitalization." | |||
There was a problem hiding this comment.
Will this not trigger warnings if we use things like POST in a heading?
There was a problem hiding this comment.
@keunes Yes, we can create an allowlist override for that (e.g. ignore rules like this for HTTP verbs like GET/POST). I usually just update rules while I'm writing if I disagree with them.
2 participants
Currently, we don't have any checks in place on our writing style or conventions. To make this easier, this PR adds Vale rules that can be used in any editor to validate that writing is consistent and follows best practice.