Fix template review findings: cruft, locale guard, docs, lint, config type-checking#18
Merged
Merged
Conversation
… type-checking - Remove stray "// hook test" / "// test" comments left in main.ts - Extend the compile-time locale key-parity guard in StringManager to cover es (and document adding one line per new locale); previously only en<->fr were checked, so a missing key in es (or any future locale) passed tsc - Drop the non-existent model.timer.timeSpeedProperty from TimeModel's doc example so the snippet compiles as written - Add a tests/** biome override for useExplicitType so the template lints clean out of the box (matching the src/** and scripts/** overrides) - Type-check the root *.config.ts files via tsconfig.scripts.json and switch playwright.config.ts to bracket access for process.env["CI"] to satisfy noPropertyAccessFromIndexSignature Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Hy8jfGtbrvpNDRxFfFx6ZA
npm audit fix bumps three transitive dev dependencies (all reachable only via vite-plugin-pwa -> workbox-build, i.e. build-time only, not shipped in the sim bundle): - brace-expansion 2.1.1 -> 2.1.2 and 5.0.6 -> 5.0.7 (GHSA-3jxr-9vmj-r5cp, DoS via exponential-time expansion) - fast-uri 3.1.2 -> 3.1.4 (GHSA-4c8g-83qw-93j6, GHSA-v2hh-gcrm-f6hx, host confusion via IDN canonicalization / backslash authority delimiter) Lockfile-only, patch-level bumps; package.json unchanged. npm audit now reports 0 vulnerabilities; check/lint/test/build all pass. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Hy8jfGtbrvpNDRxFfFx6ZA
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
es (and document adding one line per new locale); previously only en<->fr
were checked, so a missing key in es (or any future locale) passed tsc
example so the snippet compiles as written
clean out of the box (matching the src/** and scripts/** overrides)
playwright.config.ts to bracket access for process.env["CI"] to satisfy
noPropertyAccessFromIndexSignature
Co-Authored-By: Claude Opus 4.8 noreply@anthropic.com
Claude-Session: https://claude.ai/code/session_01Hy8jfGtbrvpNDRxFfFx6ZA