Skip to content

Fix template review findings: cruft, locale guard, docs, lint, config type-checking#18

Merged
veillette merged 2 commits into
mainfrom
claude/template-review-h9ll9v
Jul 22, 2026
Merged

Fix template review findings: cruft, locale guard, docs, lint, config type-checking#18
veillette merged 2 commits into
mainfrom
claude/template-review-h9ll9v

Conversation

@veillette

Copy link
Copy Markdown
Collaborator
  • Remove stray "// hook test" / "// test" comments left in main.ts
  • Extend the compile-time locale key-parity guard in StringManager to cover
    es (and document adding one line per new locale); previously only en<->fr
    were checked, so a missing key in es (or any future locale) passed tsc
  • Drop the non-existent model.timer.timeSpeedProperty from TimeModel's doc
    example so the snippet compiles as written
  • Add a tests/** biome override for useExplicitType so the template lints
    clean out of the box (matching the src/** and scripts/** overrides)
  • Type-check the root *.config.ts files via tsconfig.scripts.json and switch
    playwright.config.ts to bracket access for process.env["CI"] to satisfy
    noPropertyAccessFromIndexSignature

Co-Authored-By: Claude Opus 4.8 noreply@anthropic.com
Claude-Session: https://claude.ai/code/session_01Hy8jfGtbrvpNDRxFfFx6ZA

claude added 2 commits July 22, 2026 07:45
… type-checking

- Remove stray "// hook test" / "// test" comments left in main.ts
- Extend the compile-time locale key-parity guard in StringManager to cover
  es (and document adding one line per new locale); previously only en<->fr
  were checked, so a missing key in es (or any future locale) passed tsc
- Drop the non-existent model.timer.timeSpeedProperty from TimeModel's doc
  example so the snippet compiles as written
- Add a tests/** biome override for useExplicitType so the template lints
  clean out of the box (matching the src/** and scripts/** overrides)
- Type-check the root *.config.ts files via tsconfig.scripts.json and switch
  playwright.config.ts to bracket access for process.env["CI"] to satisfy
  noPropertyAccessFromIndexSignature

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Hy8jfGtbrvpNDRxFfFx6ZA
npm audit fix bumps three transitive dev dependencies (all reachable only
via vite-plugin-pwa -> workbox-build, i.e. build-time only, not shipped in
the sim bundle):

- brace-expansion 2.1.1 -> 2.1.2 and 5.0.6 -> 5.0.7 (GHSA-3jxr-9vmj-r5cp,
  DoS via exponential-time expansion)
- fast-uri 3.1.2 -> 3.1.4 (GHSA-4c8g-83qw-93j6, GHSA-v2hh-gcrm-f6hx, host
  confusion via IDN canonicalization / backslash authority delimiter)

Lockfile-only, patch-level bumps; package.json unchanged. npm audit now
reports 0 vulnerabilities; check/lint/test/build all pass.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Hy8jfGtbrvpNDRxFfFx6ZA
@cursor

cursor Bot commented Jul 22, 2026

Copy link
Copy Markdown

Bugbot is not enabled for your account, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

@github-actions

Copy link
Copy Markdown

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails
npm/brace-expansion 5.0.7 🟢 7.3
Details
CheckScoreReason
Security-Policy🟢 10security policy file detected
Dangerous-Workflow🟢 10no dangerous workflow patterns detected
Binary-Artifacts🟢 10no binaries found in the repo
Packaging⚠️ -1packaging workflow not detected
Code-Review🟢 4Found 7/16 approved changesets -- score normalized to 4
Maintained🟢 1018 commit(s) and 3 issue activity found in the last 90 days -- score normalized to 10
Token-Permissions🟢 10GitHub workflow tokens follow principle of least privilege
Pinned-Dependencies🟢 10all dependencies are pinned
CII-Best-Practices⚠️ 0no effort to earn an OpenSSF best practices badge detected
Fuzzing⚠️ 0project is not fuzzed
License🟢 9license file detected
Branch-Protection⚠️ -1internal error: error during branchesHandler.setup: internal error: some github tokens can't read classic branch protection rules: https://github.com/ossf/scorecard-action/blob/main/docs/authentication/fine-grained-auth-token.md
Signed-Releases⚠️ -1no releases found
SAST⚠️ 0SAST tool is not run on all commits -- score normalized to 0
npm/brace-expansion 2.1.2 🟢 7.3
Details
CheckScoreReason
Security-Policy🟢 10security policy file detected
Dangerous-Workflow🟢 10no dangerous workflow patterns detected
Binary-Artifacts🟢 10no binaries found in the repo
Packaging⚠️ -1packaging workflow not detected
Code-Review🟢 4Found 7/16 approved changesets -- score normalized to 4
Maintained🟢 1018 commit(s) and 3 issue activity found in the last 90 days -- score normalized to 10
Token-Permissions🟢 10GitHub workflow tokens follow principle of least privilege
Pinned-Dependencies🟢 10all dependencies are pinned
CII-Best-Practices⚠️ 0no effort to earn an OpenSSF best practices badge detected
Fuzzing⚠️ 0project is not fuzzed
License🟢 9license file detected
Branch-Protection⚠️ -1internal error: error during branchesHandler.setup: internal error: some github tokens can't read classic branch protection rules: https://github.com/ossf/scorecard-action/blob/main/docs/authentication/fine-grained-auth-token.md
Signed-Releases⚠️ -1no releases found
SAST⚠️ 0SAST tool is not run on all commits -- score normalized to 0
npm/fast-uri 3.1.4 UnknownUnknown

Scanned Files

  • package-lock.json

@veillette
veillette merged commit 9b51015 into main Jul 22, 2026
8 checks passed
@veillette
veillette deleted the claude/template-review-h9ll9v branch July 22, 2026 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants