Skip to content

F OpenNebula/engineering#730: Sunstone views role#176

Open
ArnauGabrielAtienza wants to merge 6 commits intoOpenNebula:masterfrom
ArnauGabrielAtienza:views
Open

F OpenNebula/engineering#730: Sunstone views role#176
ArnauGabrielAtienza wants to merge 6 commits intoOpenNebula:masterfrom
ArnauGabrielAtienza:views

Conversation

@ArnauGabrielAtienza
Copy link
Copy Markdown
Contributor

New role that does the following:

  1. Copies a local view folder into the target frontend
  2. Adds the role to /etc/one/fireedge/sunstone/views/sunstone-views.yaml
  3. Assigns this role to a list of users

Signed-off-by: ArnauGabrielAtienza <agabriel@opennebula.io>
@sk4zuzu
Copy link
Copy Markdown
Collaborator

sk4zuzu commented Mar 20, 2026

Is there any specific reason this has to be separate role? 🤔

@ArnauGabrielAtienza
Copy link
Copy Markdown
Contributor Author

Would it be better to include it as a task under the gui role?

@tinova
Copy link
Copy Markdown
Member

tinova commented Apr 9, 2026

I think best if we include it in the gui role, if @sk4zuzu agrees please @ArnauGabrielAtienza proceed

@sk4zuzu
Copy link
Copy Markdown
Collaborator

sk4zuzu commented Apr 9, 2026

@ArnauGabrielAtienza so I was thinking if you dont need this role to be reused anywhere else (and I suppose nobody does) I guess moving this code to gui role itself should be justified 🤔

Signed-off-by: ArnauGabrielAtienza <agabriel@opennebula.io>
Signed-off-by: ArnauGabrielAtienza <agabriel@opennebula.io>
Signed-off-by: ArnauGabrielAtienza <agabriel@opennebula.io>
@ArnauGabrielAtienza
Copy link
Copy Markdown
Contributor Author

ArnauGabrielAtienza commented Apr 16, 2026

@sk4zuzu Moved the role into a task inside the gui role. Please review.

- Improve performance by reducing number of task loops
- Update .gitignore
- Make various coding-style fixes

Signed-off-by: Michal Opala <sk4zuzu@gmail.com>
Copy link
Copy Markdown
Collaborator

@sk4zuzu sk4zuzu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ArnauGabrielAtienza I allowed myself to refactor it a bit 😇 , "flipping dictionaries inside-out" in ansible is quite difficult. Your solution was working, but it was suboptimal, please try to avoid unnecessary loops in ansible as the whole codebase is growing fast lately, we need to optimize as hard as we can.

You may want to consider renaming source_folder to source_dir I guess + I think you forgot to update README.md 🤔

Signed-off-by: Michal Opala <sk4zuzu@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants