F OpenNebula/engineering#730: Sunstone views role#176
F OpenNebula/engineering#730: Sunstone views role#176ArnauGabrielAtienza wants to merge 6 commits intoOpenNebula:masterfrom
Conversation
Signed-off-by: ArnauGabrielAtienza <agabriel@opennebula.io>
|
Is there any specific reason this has to be separate role? 🤔 |
|
Would it be better to include it as a task under the |
|
I think best if we include it in the gui role, if @sk4zuzu agrees please @ArnauGabrielAtienza proceed |
|
@ArnauGabrielAtienza so I was thinking if you dont need this role to be reused anywhere else (and I suppose nobody does) I guess moving this code to gui role itself should be justified 🤔 |
Signed-off-by: ArnauGabrielAtienza <agabriel@opennebula.io>
Signed-off-by: ArnauGabrielAtienza <agabriel@opennebula.io>
Signed-off-by: ArnauGabrielAtienza <agabriel@opennebula.io>
|
@sk4zuzu Moved the role into a task inside the gui role. Please review. |
- Improve performance by reducing number of task loops - Update .gitignore - Make various coding-style fixes Signed-off-by: Michal Opala <sk4zuzu@gmail.com>
sk4zuzu
left a comment
There was a problem hiding this comment.
@ArnauGabrielAtienza I allowed myself to refactor it a bit 😇 , "flipping dictionaries inside-out" in ansible is quite difficult. Your solution was working, but it was suboptimal, please try to avoid unnecessary loops in ansible as the whole codebase is growing fast lately, we need to optimize as hard as we can.
You may want to consider renaming source_folder to source_dir I guess + I think you forgot to update README.md 🤔
Signed-off-by: Michal Opala <sk4zuzu@gmail.com>
New role that does the following:
/etc/one/fireedge/sunstone/views/sunstone-views.yaml