Repository navigation
Override libzip check for snprintf on MSVC - #110
Merged
arun3688 merged 1 commit intoAug 27, 2026
Merged
Conversation
Contributor
Author
|
And here is the failed job this is supposed to fix: |
arun3688
approved these changes
Aug 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Libzip checks for snprintf, but the check does not work on modern MSVC since snprintf is declared as an inline function and not a symbol. This causes libzip to redefine snprintf, which MSVC compiler does not allow.
I believe this will solve the problem, but I have no MSVC compiler setup so I cannot test it myself.