Repository navigation
CombiTimeTable: set up the time events at construction (0.3.4) - #19
Merged
Merged
Conversation
getValue before the table's first nextTimeEvent read its unallocated event intervals and segfaulted (Blocks.Examples.Interaction1: OMBackend evaluates the model before the initialization). init2 now calls nextTimeEvent at max(startTime, first table time). Assisted-by: Claude Opus 5.5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getValue before a table's first nextTimeEvent read its unallocated event intervals and segfaulted. OMBackend evaluates the model before the initialization calls getNextTimeEvent; the MSL IntegerTable/BooleanTable (startTime = -1e60) crashed there (Blocks.Examples.Interaction1, Linux coverage). init2 now calls nextTimeEvent at max(startTime, first table time).
Checked: the new test segfaults without the change and passes with it; Interaction1 runs to t = 10 with its table outputs matching the reference; OM.jl's event-semantics tests (CombiTimeTable/BooleanTable models) 178 passed.
🤖 Generated with Claude Code