Repository navigation
Registry: validate at the default tolerance over the experiment's horizon - #13
Merged
Merged
Conversation
…izon The relaxed validation settings (atol/reltol above 0.01/3e-3, a stopTime short of the experiment's) are off the relaxed entries of models that validated: 113 for MSL 4.1.0, 123 for 3.2.3. 95 and 105 of them validate strictly (OM.jl runs at the default rule over the full horizon, cross-checked with omc); 18 per version do not: their issue notes the finding, and they count as failing until fixed. A stopTime stays only where the reference ends before the experiment; ChuaCircuit 4.1.0 goes to its reference's end, 3000 s. Expected from the next coverage runs: MSL 4.1.0 about 482/534 validate (was 500), 3.2.3 about 370/425 (was 388). Assisted-by: Claude Opus 5.5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Takes the relaxed validation settings (atol/reltol above 0.01/3e-3, a stopTime short of the experiment's) off the relaxed entries of models that validated: 113 for MSL 4.1.0, 123 for 3.2.3. Solvers, observed filters, mappings and reference files are unchanged; a stopTime stays only where the reference ends before the experiment (ChuaCircuit 4.1.0 goes to its reference's end, 3000 s).
Checked by running each relaxed model in OM.jl through the harness at the default rule over the full horizon, and against omc on a sample:
issuenotes the finding.Expected from the next coverage runs: MSL 4.1.0 about 482/534 validate (was 500), 3.2.3 about 370/425 (was 388).
🤖 Generated with Claude Code