Repository navigation
Signals a validation compared: kept in signals.json, viewed in the report - #12
Merged
Merged
Conversation
…port
compare_signal keeps the values it compared (SignalComparison times, expected,
actual); the worker returns them, passed or not, and ModelResult carries them
through the shard merge. signals_json writes them by model (shared times,
6 significant digits, null where none): generate_report beside the HTML
report, publish_site as runs/<date>/signals.json, linked from the run page and
kept for the latest 5 runs of a version (SIGNAL_RUNS_KEPT).
The report links each model's signals ("signals k/n", red when one failed): a
panel plots the reference, OM.jl's values and the tolerance band per signal,
failed first, the worst point marked; the cursor reads out the values, and a
signal's name lists all of them. The data is read on the first click (a
report opened from disk asks for the file).
Tests: signalsTests (values kept, worker tuples, JSON, report links, site
retention).
Compat OM "0.9": OM.jl master is 0.9.0 since today, outside "0.7.0".
Assisted-by: Claude Opus 5.5
JKRT
force-pushed
the
signal-inspection
branch
from
October 27, 2026 19:40
738f3d2 to
67b4561
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The coverage report now shows how a model behaved: the reference's and OM.jl's values of each signal its validation compared.
compare_signalkeeps the values it compared (101 times); the worker returns them, passed or failed, andModelResult.signalscarries them through the shard merge.signals_json/write_signals: by model, shared times, 6 significant digits.generate_reportwrites<report>.signals.jsonbeside the HTML;publish_sitewritesruns/<date>/signals.json, links it from the run page, and keeps it for the latest 5 runs of a version (SIGNAL_RUNS_KEPT). About 4-7 MB per run and MSL version.Tests:
test/signalsTests.jl; the comparison, site and signals tests pass (76). Checked on real MSL 4.1.0 models through the worker function, including a failed validation, and in the browser. The site gets the signals from the first coverage run after this is merged.Also compat
OM = "0.9": OM.jl master is 0.9.0 since today, outside the old"0.7.0", so every OMLibraryTesting CI run (this PR, master, the scheduled coverage) failed at setup with "empty intersection between OM@0.9.0 and project compatibility 0.7".🤖 Generated with Claude Code