Repository navigation
Annotation printers that work, componentGraphics; remove never-included files (1.8.2) - #109
Merged
Merged
Conversation
…ed files (1.8.2) - AbsynUtil: crefString, typeSpecString, printExp and two error messages called a Dump module that does not exist; they use Absyn.jl's printers. importString written; the partial printExp replaced. - SCodeDump: printModStr, dumpModifier, dumpAnnotation, printAnnotationStr write Modelica; unparseElementStr without templates. Removed the functions that called the unported Tpl and that nothing calls. - componentGraphics(fm, component), classGraphics(cls, connectors): a component class's icon (its base classes' items first) and its connectors' placements as Modelica text. - Deleted files no include reaches: SCodeDumpTpl.jl, AbsynDumpTpl.jl, stale top-level copies of Util/ files, test.jl, formatGeneratedJuliaCode.jl, mosScript.jl, example.mo, mechanicsEval.mos, NFUnit/NFUnitCheck/NFHashTableCrToUnit. Assisted-by: Claude Opus 5.5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AbsynUtil:crefString,typeSpecString,printExpand two error messages called aDumpmodule that does not exist (only the never-included template files imported one); they now use Absyn.jl's printers.importStringwritten; the partialprintExp(strings and arrays only) replaced.SCodeDump:printModStr,dumpModifier(it wroteIcon=coordinateSystem=...),dumpAnnotation,printAnnotationStrwrite Modelica;unparseElementStrwithout templates. Removed the functions that called the unportedTpland that nothing calls.componentGraphics(fm, component)/classGraphics(cls, connectors): a component class's icon (its base classes' items first) and its connectors' placements as Modelica text, for tools that write a replacement (a surrogate) that looks like the component. To be exposed through OM.jl'scomponentInterface.SCodeDumpTpl.jl,AbsynDumpTpl.jl, stale top-level copies ofUtil/files,test.jl,formatGeneratedJuliaCode.jl,mosScript.jl,example.mo,mechanicsEval.mos, NFUnit/NFUnitCheck/NFHashTableCrToUnit (-16k lines).Tests:
test/componentGraphicsTests.jl(18); full suite 688/688 locally. Expression parentheses come from OpenModelica/Absyn.jl#6 (merge first); this PR's tests do not depend on it.🤖 Generated with Claude Code