Repository navigation
Conversation
…ol (0.8.4) - Observed filter: the closure also seeds from the alias and eliminated variables' observations and from what events read (MSL IMC_DCBraking, SMPM_NoLoad, FullRobot). - Event iteration: a failed re-solve in a cluster's mixed system puts its return code back (SwitchYDwithArc); so does a failed re-solve at the event in the modes from before it, and the relations are read at the crossing (an arc's quench caught past its window with OrdinaryDiffEqCore 4.19); no rounding rule for a relation located at this instant; a relation hovering on its boundary gets the band at the tolerance (IMC_YDarc's quench); the memory of degenerate step restarts is reset at the start of a solve (a second solve of a cached build took another path). - Error control: every $DER_ unknown out of it, as omc controls the states only (IMC_YDarc stalled at 2.0027 s). - A failed build's module is evaluated again, so its simulate fails on the build's error. - Tests: observedFilterTests, arcSwitchTests (quench times and currents against the circuit's equations written out by hand), exactZeroRelationTests, eventIterationTests, solveKwargsTests. Assisted-by: Claude Opus 5.5
Interpolated values through canonicalSymbol instead of matching printed symbols; each arc's quench time from its opener's `quenched` instead of repeated solution times. Assisted-by: Claude Opus 5.5
The test model's switches call the state `arcOff` (MSL: `quenched`); the comments say the arc goes out rather than quenches. Assisted-by: Claude Opus 5.5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes from the MSL 4.1.0 electrical machines cluster (0.8.4):
$DER_unknown is left out of it, as omc controls only the states (IMC_YDarc stalled at 2.0027 s).Tests: observedFilterTests, arcSwitchTests (quench times and currents against the circuit's equations written out by hand), exactZeroRelationTests, eventIterationTests, solveKwargsTests. Local runs on today's packages: OMBackend 1113/1113, OM.jl suite 1878 pass / 6 broken, OMLibraryTesting 156/156. MSL 4.1.0 Electrical.Machines, Magnetic.FundamentalWave and Mechanics.MultiBody (112 models) validate 108; master's CI run tonight: 108. IMC_YDarc now validates; the 4 that don't are known (SMPM_NoLoad hallSensor, PointGravityWithPointMasses2, PlanarLoops_analytic, and EngineV6_analytic at the local memory cap).
Pairs with OpenModelica/OMLibraryTesting.jl#16 and JKRT/OM.jl#80 (branch
machines-cluster). Merge this first.🤖 Generated with Claude Code