Preserve channel Select LEDs across fader-bank changes - #92
Open
iibaranov-IG wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changing an input or bus fader bank reloads the strip bindings, but it does not re-evaluate the fixed Main Select binding. On surfaces that assert the Main Select LED during a layer change, that leaves the main LED lit even while another channel remains selected.
Refresh
SELECTED_CHANNELafter the new fader bank is loaded. The normal surface synchronization then recalculates every channel Select LED, including the fixed main strip, from the actual selected channel.Validation:
Closes #54