Repository navigation
fix: restore green builds and tests after the Oct 24 merges - #1545
Merged
Merged
Conversation
Backend - api/lib.rs: remove the stray .configure(...) line (#1539) and stop compiling the unfinished player_stats module (sqlx/PgPool, wrong tables). - api/players.rs: restore the service::players imports removed in #1542. - pairing/swiss: treat a rematch as such when the history is recorded on either player; make the 'avoidance disabled' test actually disable it. Frontend - accessibility tests render inside AuthProvider, which GamePreferencesProvider now needs. - socket tests: mock the WS ticket (#1540); default API port is 8080 (#1536). - watch page: drop the unused setLiveGames. CI - generate-contract-bindings.sh is executable, so Contract Bindings CI can run it.
…out Freighter - lib/csp.ts: the connect-src fallback was still localhost:8000 after #1536 moved the API default to 8080, so the browser blocked every API call (sign-in, matchmaking, tournaments). - walletContext: only sign through @stellar/freighter-api when isConnected() reports the extension; otherwise signTransaction() waits forever for a reply (#1541).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes main after the latest batch of merges. Locally, all backend tests pass (run against Postgres), and the frontend has 0 type errors, clean lint and 325/325 unit tests passing.
Backend
api/src/lib.rs: removes the stray.configure(crate::player_stats::configure)line from feat(backend): add online player count and rating history endpoints (BE-125) #1539, which broke compilation. Also stops compiling the unfinishedplayer_statsmodule, which usessqlx/PgPooland tables that don't exist; there's a comment on feat(backend): add online player count and rating history endpoints (BE-125) #1539 explaining what's needed.api/src/players.rs: restores theservice::playersimports that fix(api): make register the single account-creation path and remove POST /v1/players (BE-102) #1542 removed.pairing/src/swiss.rs: a rematch was only detected from the head player's own history. Both sides are now checked. The "avoidance disabled" test now actually disables avoidance.Frontend
AuthProvider, whichGamePreferencesProviderneeds (since Add player preference sync #1528).app/watch/page.tsx: removes the unusedsetLiveGames.CI
frontend/scripts/generate-contract-bindings.shis now executable, so Contract Bindings CI can run it.