Skip to content

test(ssh): the continuation-backslash paste test lost its line break - #83

Merged
keyldev merged 1 commit into
mainfrom
fix/terminal-paste-test
Oct 3, 2026
Merged

keyldev merged 1 commit into
mainfrom
fix/terminal-paste-test

Conversation

@keyldev

@keyldev keyldev commented Oct 3, 2026 •

Copy link
Copy Markdown
Collaborator
  • The test string had a literal \n instead of a backslash followed by a newline
  • Production paste code is unchanged; the full suite passes locally

Summary

Related

Type

  • Bug fix
  • Feature
  • Refactor / cleanup
  • Docs / CI
  • Other:

Checklist

  • Builds with 0 warnings (TreatWarningsAsErrors=true).
  • Tests pass (dotnet test); new Core logic has unit tests.
  • No layering violation — App references Core only (Infrastructure / Video / Devices wired via DI in a head).
  • Scope stays within one phase (didn't pull work from a later phase's "Не входит").
  • README / docs updated if public commands, options, or setup changed.

Platforms tested

  • Windows
  • Linux
  • macOS
  • Android
  • iOS
  • CI build only

Screenshots / notes

- The test string had a literal \n instead of a backslash followed by a newline
- Production paste code is unchanged; the full suite passes locally
@keyldev
keyldev merged commit b01bcd4 into main Oct 3, 2026
5 checks passed
@qodo-free-for-open-source-projects

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Grey Divider

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Grey Divider

Tip of the day
💡 Did you know, you can copy the agent prompt from any finding and feed it to your IDE agent

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗

Grey Divider

Qodo Logo

@qodo-free-for-open-source-projects

Copy link
Copy Markdown

PR Summary by Qodo

Restore the newline in the SSH paste continuation test

🧪 Tests 🐞 Bug fix 🕐 Less than 5 minutes

Grey Divider

AI Description

• Replaces a literal backslash-n with a backslash followed by a newline in the test input.
• Restores coverage for joining a continued command; production paste code is unchanged.
High-Level Assessment

Correcting the test input directly is the appropriate approach: it exercises the intended continuation-backslash behavior without changing production code.

Files changed (1) +1 / -1

Tests (1) +1 / -1
TerminalPasteTests.csRestore a real line break after the continuation backslash +1/-1

Restore a real line break after the continuation backslash

• The test input now contains a backslash followed by a newline instead of the literal characters backslash and n. This makes the existing line-count and joined-command assertions exercise the intended multiline paste.

tests/OpenIPC.Viewer.Core.Tests/Ssh/TerminalPasteTests.cs

@keyldev
keyldev deleted the fix/terminal-paste-test branch October 4, 2026 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant