Repository navigation
ci: the version check runs in a workflow of its own (#244) - #245
Merged
Merged
Conversation
Adding or removing a label re-ran the whole build, because build.yml listened to labeled/unlabeled for the version check. The check moves to .github/workflows/version.yml, the only workflow on label events; build.yml runs on the usual pull request events again.
PR Summary by QodoRun v2 version checks in a separate workflow
AI Description
Diagram
High-Level Assessment
Files changed (4)
|
Code Review by Qodo🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)
Great, no issues found!Qodo reviewed your code and found no material issues that require reviewTip of the day💡 Did you know, you can move or hide resolved findings to focus on what still needs action |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #244.
.github/workflows/version.yml(new): the version check of pull requests tov2, onopened,synchronize,reopened,labeledandunlabeled;.github/check-version.sh HEAD^1withNO_RELEASEfrom theno-releaselabel; a newer event of the same pull request cancels the older check. As in ci: check-version.sh compares with HEAD^1, counts build.yml as build, no-release label (#68, #69) camex#71.build.yml: theversionjob and the label event types are gone, so adding or removing a label no longer rebuilds the APKs. No job needed the removed one; the build and publication are unchanged.basicis not touched.check-version.shanddocs/testing.mdsay where the check runs;version.ymlandpublish-latest.share CI,build.ymlstays build.Checked locally: shellcheck v0.10.0 on the script; both workflows parse;
check-version.sh origin/v2on this branch fails withoutNO_RELEASE(build.ymlchanged, 2.17 kept) and passes withNO_RELEASE=true. CI only, the APKs do not change:no-release, no version bump.