Skip to content

ci: the version check runs in a workflow of its own (#244) - #245

Merged
compot-dev merged 1 commit into
v2from
version-workflow
Oct 18, 2026
Merged

compot-dev merged 1 commit into
v2from
version-workflow

Conversation

@compot-dev

Copy link
Copy Markdown
Collaborator

Closes #244.

  • .github/workflows/version.yml (new): the version check of pull requests to v2, on opened, synchronize, reopened, labeled and unlabeled; .github/check-version.sh HEAD^1 with NO_RELEASE from the no-release label; a newer event of the same pull request cancels the older check. As in ci: check-version.sh compares with HEAD^1, counts build.yml as build, no-release label (#68, #69) camex#71.
  • build.yml: the version job and the label event types are gone, so adding or removing a label no longer rebuilds the APKs. No job needed the removed one; the build and publication are unchanged. basic is not touched.
  • check-version.sh and docs/testing.md say where the check runs; version.yml and publish-latest.sh are CI, build.yml stays build.

Checked locally: shellcheck v0.10.0 on the script; both workflows parse; check-version.sh origin/v2 on this branch fails without NO_RELEASE (build.yml changed, 2.17 kept) and passes with NO_RELEASE=true. CI only, the APKs do not change: no-release, no version bump.

Adding or removing a label re-ran the whole build, because build.yml
listened to labeled/unlabeled for the version check. The check moves to
.github/workflows/version.yml, the only workflow on label events;
build.yml runs on the usual pull request events again.
@compot-dev compot-dev added uni Release naming and management, common across the repositories no-release Changes the build or the code without changing the binaries: no new version, no release labels Oct 18, 2026
@qodo-free-for-open-source-projects

Copy link
Copy Markdown

PR Summary by Qodo

Run v2 version checks in a separate workflow

⚙️ Configuration changes 📝 Documentation 🕐 10-20 Minutes

Grey Divider

AI Description

• Move v2 pull-request version checks into a dedicated workflow that responds to label changes.
• Stop label changes from rerunning the build workflow; leave build and publication jobs unchanged.
• Document where version checks run and cancel superseded checks for the same pull request.
Diagram

graph TD
  P["PR update"] --> V["Version workflow"] --> C["Version check"]
  L["Label change"] --> V
  P --> B["Build workflow"] --> T["Tests and lint"]
Loading
High-Level Assessment

A separate workflow is the appropriate boundary: it lets label changes recheck version policy without triggering build tests. Keeping the existing script avoids duplicating validation logic; filtering label events inside the build workflow would still start unnecessary workflow runs.

Files changed (4) +47 / -23

Documentation (2) +5 / -1
check-version.shDocument the check’s new CI location +4/-0

Document the check’s new CI location

• Adds comments identifying the dedicated version workflow as the script’s CI caller and clarifying that the version workflow and publication script are CI, not build inputs. Validation behavior is unchanged.

.github/check-version.sh

testing.mdClarify version-check workflow behavior +1/-1

Clarify version-check workflow behavior

• Identifies the dedicated workflow as the v2 pull-request version check and explains that label changes rerun the check without rerunning the build.

docs/testing.md

Other (2) +42 / -22
build.ymlRemove version checks and label triggers from Build +1/-22

Remove version checks and label triggers from Build

• Removes the version job and explicit pull-request event list, so label changes no longer start the build workflow. The remaining test, build, and publication jobs are unchanged.

.github/workflows/build.yml

version.ymlAdd a dedicated v2 version-check workflow +41/-0

Add a dedicated v2 version-check workflow

• Runs the existing version script for v2 pull requests on open, synchronize, reopen, label, and unlabel events, passing the no-release label state. Cancels an older check when a newer event arrives for the same pull request.

.github/workflows/version.yml

@qodo-free-for-open-source-projects

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Grey Divider

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Grey Divider

Tip of the day
💡 Did you know, you can move or hide resolved findings to focus on what still needs action

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗

Grey Divider

Qodo Logo

@compot-dev
compot-dev merged commit fd47032 into v2 Oct 18, 2026
7 of 9 checks passed
@compot-dev
compot-dev deleted the version-workflow branch October 18, 2026 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-release Changes the build or the code without changing the binaries: no new version, no release uni Release naming and management, common across the repositories

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CI: the version check in a workflow of its own

1 participant