Repository navigation
feat: menu as an 8 / 4 / 4 grid with words; debug page Info Off by default (#174, #176, #177) - #178
Conversation
|
/review |
Code Review by Qodo
1. Remote navigation stops at grey cells
|
| setSingleViewItems(single); | ||
| linkRemote(camButtons, | ||
| new TextView[]{mSettingsBtn, mWebUiBtn, quadBtn, slidesBtn}, | ||
| new TextView[]{exit, reset, statsBtn, udpBtn}); |
There was a problem hiding this comment.
1. Remote navigation stops at grey cells 📎 Requirement gap ≡ Correctness
linkRemote sends slots 1–4 directly to the Settings and WebUI cells, while setSingleViewItems(false) makes those cells disabled and unfocusable. In multi-view or UDP view, pressing Down from those slots therefore cannot reach the lower rows, so the remote cannot navigate through the full menu grid.
Agent Prompt
## Issue description
Remote navigation maps slots 1–4 to the disabled Settings and WebUI cells, which prevents focus from moving into the lower menu rows in multi-view and UDP view.
## Fix Focus Areas
- android/app/src/main/java/com/openipc/decoder/MenuManager.java[394-400]
- android/app/src/main/java/com/openipc/decoder/MenuManager.java[407-418]
## Recommended Fix
Configure explicit directional focus links that bypass disabled Settings and WebUI cells, or make the navigation logic advance past disabled targets while keeping those cells visible, grey, and non-activatable.
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
… ellipsized), LABORATORY: the grid menu from 2.06, remote check for the grid
7119b1e to
006c1d4
Compare
|
Qodo on 7119b1e:
|
Thanks for the follow-up. Your AG-216 validation addresses finding 1, and commit
No further review action is needed from me based on this evidence. |
… ellipsized), LABORATORY: the grid menu from 2.06, remote check for the grid
Replaces #175 (its commits are included).
Menu (#177)
Debug page (#174): Info Off until switched on; the snapshot interval default stays 5 s.
README (EN/RU/ZH) menu section and LABORATORY's menu notes updated. Version 2.06.
Closes #174
Closes #176
Closes #177