Skip to content

feat: debug page Info switch — header and snapshot only (#141) - #142

Merged
compot-dev merged 2 commits into
v2from
feat/debug-compact
Oct 13, 2026
Merged

compot-dev merged 2 commits into
v2from
feat/debug-compact

Conversation

@compot-dev

Copy link
Copy Markdown
Collaborator

Closes #141.

A switch Info On / Off in the header of the debug page (port 8085), left of the snapshot interval:

  • On (default): as before — slot, address, transport, codec, size, fps, losses over each cell; the list below on a narrow screen.
  • Off: the header line and the snapshot's nine cells only — no text over the cells, no cell borders, no list.

Remembered in the browser (localStorage), like the snapshot interval. Page only, no app logic touched.

Checked with the page rendered in headless Chrome against the live AG-216 (stats and snapshot from .144:8085), both states.

…t only (#141)

Co-Authored-By: Claude <noreply@anthropic.com>
@compot-dev

Copy link
Copy Markdown
Collaborator Author

/review

@qodo-free-for-open-source-projects

qodo-free-for-open-source-projects Bot commented Oct 13, 2026 •

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0) 🎨 UX issues (0) 🔗 Cross-repo conflicts (0) 📜 Skill insights (0)

Grey Divider


Remediation recommended

1. Narrow screens push controls off-screen ✓ Resolved
Description
The new Info control expands the unwrapped nav beyond the available width on narrow viewports.
Because the header can wrap only its direct children while nav uses white-space:nowrap, the
JSON, Log, Info, and Snapshot controls overflow horizontally and may be inaccessible without
scrolling.
Code

android/app/src/main/java/com/openipc/decoder/DebugServer.java[R464-465]

+            + "<span>Info<span class=\"seg\" id=\"info\"><button value=\"1\">On</button>"
+            + "<button value=\"0\">Off</button></span></span>"
Evidence
The new Info label and two buttons are added inside nav, whose white-space:nowrap prevents its
contents from wrapping. The header's flex-wrap applies only to direct header children, and no
overflow rule is applied to the header or body; the existing overflow rule applies only to main,
so the expanded navigation can exceed a narrow viewport.

android/app/src/main/java/com/openipc/decoder/DebugServer.java[420-421]
android/app/src/main/java/com/openipc/decoder/DebugServer.java[464-467]
android/app/src/main/java/com/openipc/decoder/DebugServer.java[431-433]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
The added Info control makes the header navigation wider than common narrow viewports, while the navigation is explicitly kept on one line. This causes the header controls to overflow horizontally on the narrow-screen layout.
### Fix Focus Areas
- android/app/src/main/java/com/openipc/decoder/DebugServer.java[420-421]
- android/app/src/main/java/com/openipc/decoder/DebugServer.java[464-467]
### Recommended Fix
Allow the navigation contents to wrap or provide a responsive narrow-screen layout for the controls. Preserve the existing header spacing and ensure JSON, Log, Info, and Snapshot remain reachable within the viewport without relying on page-wide horizontal scrolling.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools


Grey Divider

Tip of the day
💡 Did you know, you can turn these tips off under Display > Comment parts

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗

Grey Divider

Qodo Logo

Co-Authored-By: Claude <noreply@anthropic.com>
@compot-dev

Copy link
Copy Markdown
Collaborator Author

Qodo: Narrow screens push controls off-screen — fixed in 3d06187: nav wraps its groups (JSON, Log, Info, Snapshot each stay on one line). Rendered against the live AG-216 at 390 px (controls on two rows under the title, nothing off-screen) and 1400 px (one header line as before).

@compot-dev

Copy link
Copy Markdown
Collaborator Author

/review

@qodo-free-for-open-source-projects

Copy link
Copy Markdown

Code review by qodo was updated up to the latest commit 3d06187

@compot-dev
compot-dev merged commit 52a33c1 into v2 Oct 13, 2026
4 checks passed
@compot-dev
compot-dev deleted the feat/debug-compact branch October 13, 2026 15:50
compot-dev added a commit that referenced this pull request Oct 15, 2026
Co-Authored-By: Claude <noreply@anthropic.com>
compot-dev added a commit that referenced this pull request Oct 15, 2026
feat: debug page Info switch — header and snapshot only (#141)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Debug page: switch to hide the cell info (clean view: header + 9 cells only)

1 participant