Skip to content

fix: set up one decoder at a time — nine at once stalled SurfaceFlinger (#76) #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
compot-dev wants to merge 3 commits into from
Closed

fix: set up one decoder at a time — nine at once stalled SurfaceFlinger (#76) #127

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
48e5449
fix: a stopped grid cell closes its decoder in surfaceDestroyed, befo…
compot-dev Oct 13, 2026
4414500
fix: set up one decoder at a time, 250 ms apart — nine at once stalle…
compot-dev Oct 13, 2026
0b87b46
Revert "fix: a stopped grid cell closes its decoder in surfaceDestroy…
compot-dev Oct 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 28 additions & 10 deletions android/app/src/main/java/com/openipc/decoder/MediaCodecManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,6 +257,11 @@ private static long nowMs() {
return System.nanoTime() / 1_000_000;
}

/** Decoders are set up one after another, at least CREATE_GAP_MS apart (#76). */
private static final Object CREATE_LOCK = new Object();
static final long CREATE_GAP_MS = 250;
private static long lastCreateMs;

void createDecoder(boolean codecH265) {
final int gen;
synchronized (decoderLock) {
Expand Down Expand Up @@ -290,17 +295,30 @@ void createDecoder(boolean codecH265) {

MediaCodec local;
try {
Log.i(TAG, "Start video decoder (" + type + ")");
local = MediaCodec.createDecoderByType(type);
learnLimits(local, type);
try {
local.configure(format, s, null, 0);
local.start();
if (listener != null) listener.onDecoderStarted();
} catch (Exception e) {
local.release();
throw e;
// One decoder set up at a time, with a gap: the 3x3 grid used to start up to nine
// at once, and on the AG-216 that stalled SurfaceFlinger for tens of seconds (#76)
synchronized (CREATE_LOCK) {
long wait = lastCreateMs + CREATE_GAP_MS - nowMs();
if (wait > 0) Thread.sleep(wait);
Log.i(TAG, "Start video decoder (" + type + ")");
local = MediaCodec.createDecoderByType(type);
learnLimits(local, type);
try {
local.configure(format, s, null, 0);
local.start();
} catch (Exception e) {
local.release();
throw e;
} finally {
lastCreateMs = nowMs();
}
}
if (listener != null) listener.onDecoderStarted();
} catch (InterruptedException e) {
// The cell stopped while waiting for its turn: nothing was created
Thread.currentThread().interrupt();
InstanceBudget.release(type);
return;
} catch (Exception e) {
InstanceBudget.release(type);
synchronized (decoderLock) {
Expand Down
Loading