Skip to content

feat: menu — active items in orange, the focus frame stays blue (#114) - #116

Merged
compot-dev merged 1 commit into
v2from
feat/menu-active-orange
Oct 13, 2026
Merged

compot-dev merged 1 commit into
v2from
feat/menu-active-orange

Conversation

@compot-dev

Copy link
Copy Markdown
Collaborator

Closes #114.

  • Active / on items (D on, Q in multi-view, U in the U view, the active slot in single view): dark orange fill and an orange border.
  • The focused item (remote, Menu cannot be operated with the remote control #91): a thick blue border.
  • Both at once: orange fill under the blue border, so neither state hides the other.
  • Before, the active highlight was a blue border too, and the focus listener replaced the background, so moving the focus over an active item lost its highlight; both are now painted from one place (paintItem).

Device check: menu with the remote in multi-view (Q orange) and single view (slot orange), D on/off.

@compot-dev

Copy link
Copy Markdown
Collaborator Author

/review

@qodo-free-for-open-source-projects

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Grey Divider

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Grey Divider

Tip of the day
💡 Did you know, you can turn these tips off under Display > Comment parts

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗

Grey Divider

Qodo Logo

@compot-dev

Copy link
Copy Markdown
Collaborator Author

Device check on Aceline-1 (build 0242d14, remote): menu in multi-view with D on — D and Q have the orange fill and border; the focus (blue border) on Q, then on D after LEFT, drawn over the orange fill; the other buttons grey.

@compot-dev
compot-dev merged commit f938a62 into v2 Oct 13, 2026
4 checks passed
@compot-dev
compot-dev deleted the feat/menu-active-orange branch October 13, 2026 10:49
compot-dev added a commit that referenced this pull request Oct 15, 2026
feat: menu — active items in orange, the focus frame stays blue (#114)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Menu: active toggles (D, Q, U, active slot) highlighted in orange, not in the focus blue

1 participant