Skip to content

feat: menu order 1–8 U D Q; corner text in every cell or in none, by D (#92, #93) - #109

Merged
compot-dev merged 2 commits into
v2from
feat/menu-order-stats
Oct 13, 2026
Merged

compot-dev merged 2 commits into
v2from
feat/menu-order-stats

Conversation

@compot-dev

Copy link
Copy Markdown
Collaborator

Closes #92, closes #93.

#93 — menu order 1 2 3 4 5 6 7 8 U D Q (was Q 1–8 U D). Remote navigation (#91) is unchanged: opening the menu focuses the active item (slot, Q or U); the row still scrolls with the focus.

#92 — corner text: all cells or none. Cause of the report: with D off, #86 showed the corner text only for cells that needed attention, so the one full-rate cell had none while the others did. Now D decides for every cell: on — every cell shows resolution, codec, fps / key frames or its status; off — no cell shows text. Paused or disconnected cells stay black without text while D is off; the debug page (:8085) always shows every cell's state.

READMEs (EN/RU/ZH): menu table in the new order, D described as all-or-none.

Device check: menu order and remote navigation; D on/off in multi-view (all / none).

@compot-dev

Copy link
Copy Markdown
Collaborator Author

/review

@qodo-free-for-open-source-projects

qodo-free-for-open-source-projects Bot commented Oct 13, 2026 •

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0) 🎨 UX issues (0) 🔗 Cross-repo conflicts (0) 📜 Skill insights (0)

Grey Divider


Action required

1. Android tests fail to compile ✓ Resolved
Description
QuadCell.needsAttention() has been removed, but CellStatsTest.playingShowsCodecAndRates() still
calls it in two assertions. Compiling the Android unit tests reaches both calls, preventing the
suite from running and verifying the changed multi-view corner-text behavior.
Code

android/app/src/main/java/com/openipc/decoder/QuadCell.java[L340-343]

-    /** Something worth showing even without the debug text (D): not playing at full rate. */
-    boolean needsAttention() {
-        return pausedReason != null || problem != null || !"connected".equals(state) || keyFramesOnly;
-    }
Evidence
The test contains two calls to c.needsAttention(), while the current QuadCell source proceeds
from its frame-rate accessors directly to isPaused() with no needsAttention() implementation.
Those unresolved calls prevent the unit-test source from compiling.

Multi-view corner text follows the D-button state
android/app/src/test/java/com/openipc/decoder/CellStatsTest.java[58-64]
android/app/src/main/java/com/openipc/decoder/QuadCell.java[337-344]
android/app/src/test/java/com/openipc/decoder/CellStatsTest.java[53-63]
android/app/src/main/java/com/openipc/decoder/QuadCell.java[337-342]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
`CellStatsTest` still calls the removed `QuadCell.needsAttention()` method, preventing Android unit-test compilation and leaving the changed corner-text behavior unverified.
## Fix Focus Areas
- android/app/src/main/java/com/openipc/decoder/QuadCell.java[340-343]
- android/app/src/test/java/com/openipc/decoder/CellStatsTest.java[53-64]
## Recommended Fix
Remove the obsolete attention assertions and their outdated expectation from `CellStatsTest`, then test the new all-or-none D-button visibility behavior where view visibility is set. If `needsAttention()` remains part of the intended test contract, retain the method instead. Ensure the Android unit-test source compiles and covers the changed corner-text behavior.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools


Grey Divider

Tip of the day
💡 Did you know, you can turn these tips off under Display > Comment parts

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗

Grey Divider

Qodo Logo

@compot-dev

Copy link
Copy Markdown
Collaborator Author

Device check on Aceline-1 (build 5b8dc79): menu row 1 2 3 4 5 6 7 8 U D Q, the focus on Q when opened in multi-view; D off → no corner text in any cell; D (selected with the remote) on → text in all 8 cells and http://172.17.32.144:8085/ in the corner.

@compot-dev
compot-dev merged commit d2b7fde into v2 Oct 13, 2026
4 checks passed
@compot-dev
compot-dev deleted the feat/menu-order-stats branch October 13, 2026 10:01
compot-dev added a commit that referenced this pull request Oct 15, 2026
feat: menu order 1–8 U D Q; corner text in every cell or in none, by D (#92, #93)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Menu button order: 1 2 3 4 5 6 7 8 U D Q Multi-view corner text: all cells or none, by the D button

1 participant