Repository navigation
ci: a code change must come with a new version (#63) - #65
Merged
Merged
Conversation
.github/check-version.sh, the script of OpenIPC/vectis with camex's version macro and paths: a pull request that changes src/, android/, the Makefile, ci/ or scripts/ must raise CAMEX_VERSION (MAJOR.MINOR.PATCH without leading zeros, greater than the base) and add its new '## X.Y.Z — YYYY-MM-DD' section to CHANGELOG.md. Docs, tests, screenshots and .github/ need no new version. The "Version bump" job runs it on every pull request. READMEs: a "When to bump" section with the rule.
PR Summary by QodoRequire version bumps for code and build changes in pull requests
AI Description
Diagram
High-Level Assessment
Files changed (5)
|
Code Review by Qodo🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)
Great, no issues found!Qodo reviewed your code and found no material issues that require reviewTip of the day💡 Did you know, you can see how risky a PR is at a glance with blast radius labels |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #63.
What changes
.github/check-version.sh: the script of OpenIPC/vectis (vectis#42), so the check is the same across the repositories; only the version macro (CAMEX_VERSIONinsrc/version.h) and the code paths differ. It fails when:src/,android/,Makefile,ci/orscripts/changed against the base, but the version did not;MAJOR.MINOR.PATCHwithout leading zeros, or not greater than the base one (sort -V);CHANGELOG.mdhas no## X.Y.Z — YYYY-MM-DDsection for it, or the section is already on the base branch.Docs, tests, screenshots and the workflows in
.github/need no new version.ci/counts as build, becauseci/build-musl.shproduces the release binaries.build.yml: a "Version bump" job on pull requests (fetch-depth: 0, the base branch passed through the environment).README (en/ru/zh-CN, one commit): a "When to bump" section in "Versioning & Release Process" — PATCH/MINOR/MAJOR, which paths need a bump, what CI checks, and that the check is red until the bump commit is pushed.
Checked locally (scratch clone, base
origin/masterat 3.0.2)src/changed, version 3.0.2## 3.0.3 — 2026-10-183.0.013.0.1tests/onlyci/build-musl.shonlyThis PR changes only
.github/and the READMEs, so its own "Version bump" job should pass without a new version.