Repository navigation
Conversation
The tests use ck_assert, ck_assert_msg, ck_assert_int_eq and ck_assert_str_eq, which Check added in 0.9.6 on top of fail_unless, so they never compiled against the 0.9.4 that README.md, CMakeLists.txt and configure.ac declared as the minimum. Define the four in check_cjose.h when check.h does not, using 0.9.6's definitions, with the integer comparison printing intmax_t like later releases do. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Signed-off-by: Hans Zandbelt <hans.zandbelt@openidc.com>
Signed-off-by: Hans Zandbelt <hans.zandbelt@zmartzone.eu>
This reverts commit 457e511. The bump was the alternative to cisco#159: the tests used ck_assert_uint_eq, which arrived in Check 0.10.0, and raising the documented minimum to 0.12.0 made the requirement true. With the two ck_assert_uint_eq uses gone (cisco#159) and the ck_assert family provided for 0.9.4 and 0.9.5, the tests build and pass against every Check release from 0.9.4 to 0.15.2, so the minimum can go back to the 0.9.4 that README.md, CMakeLists.txt and configure.ac declared before. That keeps RHEL 6 (Check 0.9.8) and RHEL 7 (0.9.9) able to run the test suite in the 0.x line; 1.0.x is free to raise the floor. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Signed-off-by: Hans Zandbelt <hans.zandbelt@openidc.com>
The other workflows test with the Check that the platform packages provide, which is a recent release, so the declared minimum of 0.9.4 went unverified: the tests needed 0.10.0 for ck_assert_uint_eq and 0.9.6 for the ck_assert family. Add a Check workflow that builds the declared minimum, the releases of RHEL 7 (0.9.9) and RHEL 8 (0.12.0) and the 0.10.0 of Ubuntu 18.04 to 20.04 and Debian 9 and 10 from source (sha256 pinned, cached across runs), points cmake at them through pkg-config, checks with ldd that check_cjose loads that library, and runs the tests. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Signed-off-by: Hans Zandbelt <hans.zandbelt@openidc.com>
zandbelt
force-pushed
the
check-0.9.4-compat
branch
from
September 11, 2026 12:25
e7301ab to
befc40f
Compare
Member
Author
|
Validation done: opened upstream as cisco#172 (Check 0.9.4, 0.9.9, 0.10.0 and 0.12.0 all green here). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Validation run inside the fork for a workflow change. Four commits: the ck_assert family shim for Check 0.9.4/0.9.5, the two-line cisco#159 change (cherry-picked), the revert of the 0.12.0 minimum bump, and a
Checkworkflow that builds 0.9.4, 0.9.9, 0.10.0 and 0.12.0 from source and runs the tests against them. Expected: all green.🤖 Generated with Claude Code