fix: make sandbox resume state-aware - #252
Open
aivong-openhands wants to merge 1 commit into
Open
Conversation
Co-authored-by: openhands <openhands@all-hands.dev>
6 tasks
Coverage reportClick to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||||||||||||||||||||||||||
aivong-openhands
marked this pull request as ready for review
August 26, 2026 21:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HUMAN:
Not yet tested by a human.
AGENT:
Implemented and validated by OpenHands. This PR was created by an AI agent (OpenHands) on behalf of the user.
Why
Repeated resume requests currently perform sandbox-limit cleanup and Runtime API resume calls before resolving the target state. Active or transitioning runtimes can therefore trigger expensive work, key churn, and Runtime API conflicts that are flattened into application 404 responses.
Summary
Issue Number
Closes #245
How to Test
Validated locally:
Video/Screenshots
Not applicable; this is an application API and service behavior change.
Type
Notes
STARTINGandRUNNINGare safe no-op outcomes: no resume request is sent and no session key is returned or rotated.PAUSEDandERRORperform a real resume with enforced key rotation. Missing runtimes remain 404, state conflicts remain 409, and upstream failures use 502.@aivong-openhands can click here to continue refining the PR
Enterprise server image for this PR: