refactor: remove v1_enabled compatibility surface - #215
Draft
saurya wants to merge 3 commits into
Draft
Conversation
Co-authored-by: openhands <openhands@all-hands.dev>
|
|
saurya
changed the title
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Co-authored-by: openhands <openhands@all-hands.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HUMAN:
AGENT:
OpenHands
Why
After all conversation behavior moved to V1,
v1_enabledremained as an inactive compatibility surface across settings, organization APIs, persistence models, frontend types, and Slack conversation records. Keeping it implied a supported V0 mode that no longer exists.Summary
DEFAULT_V1_ENABLEDand all runtime defaulting/propagation.v1_enabledfrom settings and organization API/frontend models.No false/null backfill is included; the obsolete columns are dropped directly.
Issue Number
N/A
How to Test
cd frontend && npm test -- __tests__/components/features/home/new-conversation.test.tsx __tests__/components/features/home/task-card.test.tsx __tests__/components/modals/skills/skill-modal.test.tsx __tests__/hooks/mutation/use-create-conversation.test.tsx __tests__/hooks/query/use-organizations.test.tsx __tests__/routes/app-settings.test.tsx __tests__/routes/llm-settings.test.tsx src/routes/device-verify.test.tsxcd frontend && npm run lintcd frontend && npm run buildpre-commit run --config ./dev_config/python/.pre-commit-config.yamlThe affected backend pytest suites could not start in the current environment because the enterprise-only
python-keycloakdependency is not installed. Repository pre-commit, Ruff, MyPy, frontend tests, lint, and build all passed.Video/Screenshots
Not included; this removes inactive compatibility fields without changing rendered layout.
Type
Notes
Stacked on #214, which is stacked on #213. Audit item 3 (data backfill) is intentionally excluded.
This PR was created by an AI agent (OpenHands) on behalf of the user.
Enterprise server image for this PR: