Skip to content

fix(auth): show retryable signup failures - #187

Draft
neubig wants to merge 2 commits into
mainfrom
fix/keycloak-signup-retry-ux
Draft

fix(auth): show retryable signup failures#187
neubig wants to merge 2 commits into
mainfrom
fix/keycloak-signup-retry-ux

Conversation

@neubig

@neubig neubig commented Aug 17, 2026

Copy link
Copy Markdown
Member

Summary

  • redirect browser-based Keycloak connection failures back to the login page instead of exposing raw 500/503 responses
  • propagate exhausted Keycloak retries during duplicate-email signup checks and handle late provider-token setup failures
  • show persistent, localized guidance telling users their account is safe and they can restart sign-in
  • preserve safe relative post-login destinations when redirecting after an outage

Validation

  • PYTHONPATH=. poetry run pytest tests/unit/test_auth_routes.py -q (57 passed)
  • npm run test -- --run __tests__/routes/login.test.tsx (23 passed)
  • npm run typecheck:staged
  • npm run check-translation-completeness
  • npm run build
  • pre-commit run --config ./dev_config/python/.pre-commit-config.yaml

Notes

  • The repository pre-commit hook’s frontend ESLint step currently resolves incompatible parent-worktree packages and fails inside @typescript-eslint/no-unused-expressions; the changed frontend files passed TypeScript, Prettier, focused tests, translation completeness, and the production build.

This pull request was created by an AI agent (OpenHands) on behalf of the user.


Enterprise server image for this PR:

ghcr.io/openhands/enterprise-server:sha-0be53cf

Co-authored-by: openhands <openhands@all-hands.dev>
@github-actions github-actions Bot added the type: fix A bug fix label Aug 17, 2026
@github-actions

github-actions Bot commented Aug 17, 2026

Copy link
Copy Markdown

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  enterprise/server/auth/user
  default_user_authorizer.py 80-86
  enterprise/server/routes
  auth.py 92-99, 319-348, 501-510
Project Total  

This report was generated by python-coverage-comment-action

Co-authored-by: openhands <openhands@all-hands.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: fix A bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant