You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
chore: replace crates.io logind-zbus with trimmed in-tree client - #442
Add a workspace logind-zbus crate with only the org.freedesktop.login1.Manager surface used by asusd and asus-shutdown (inhibit, lid/power properties, prepare-for-shutdown/sleep signals).
Point the workspace dependency at the path crate instead of the unmaintained crates.io release, so we can evolve the binding (including a future zbus 6 bump) in-tree.
Flatten the public API to the crate root (logind_zbus::{InhibitType, ManagerProxy}).
Rationale
logind-zbus has been abandoned by @flukejones and it's not compatible with future versions of zbus (6+). As we don't need the full code but a small part of it it's better to pick it up ourselves and update alongside the rest of the package instead of waiting for the crate version.
Replace the crates.io dependency with a workspace crate that only
exposes the Manager methods asusd and asus-shutdown use, so the
binding can track zbus without an unmaintained upstream release.
Signed-off-by: Marco Scardovi <scardracs@disroot.org>
Drop the unused manager module path so callers import InhibitType and
ManagerProxy directly from logind_zbus.
Signed-off-by: Marco Scardovi <scardracs@disroot.org>
No actionable comments were generated in the recent review.
Recent review info
Run configuration
Source mode: Auto
Repository: Unavailable
Branch: Unavailable
File: No configuration file from this repository applied
Commit: Unavailable
Layers: Repository UI
Review profile: ASSERTIVE
Plan: Advanced
Run ID: d887f743-7e76-494e-a2d9-6bf1056ec2b0
Commits
Reviewing files that changed from the base of the PR and between f537fca and 1cf486a.
Files ignored due to path filters: 1
Cargo.lock is excluded by !**/*.lock
Files selected for processing: 7
Cargo.toml
asus-shutdown/src/main.rs
asusd/src/aura_anime/trait_impls.rs
asusd/src/aura_laptop/mod.rs
asusd/src/lib.rs
logind-zbus/Cargo.toml
logind-zbus/src/lib.rs
Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 2 remain after this review.
Updated the app’s integration with system power-management services. Existing behavior remains unchanged.
No user-facing features or behavior changes are included in this update.
The workspace now uses a local logind-zbus package. The package defines InhibitType and a proxy for the login1 Manager interface. Existing consumers import ManagerProxy and InhibitType from the crate root.
Changes: logind-zbus integration
Layer / File(s)
Summary
Define the local logind-zbus API logind-zbus/Cargo.toml, logind-zbus/src/lib.rs
Adds the package manifest, InhibitType string conversions and serialization, and the login1 Manager proxy with inhibition, properties, and preparation signals.
Wire workspace and consumers Cargo.toml, asus-shutdown/src/main.rs, asusd/src/aura_anime/trait_impls.rs, asusd/src/lib.rs, asusd/src/aura_laptop/mod.rs
Adds logind-zbus to the workspace and uses the crate-root exports in consumer imports. The aura_laptop change does not alter behavior.
The local client replacement has no identified merge-blocking issue.
Pre-merge checks: 4
Check name
Status
Explanation
Title check
The title clearly identifies the primary change: replacing the crates.io dependency with a trimmed in-tree client.
Description check
The description provides a clear summary, rationale, and test plan. It does not include the requested hardware and environment details, issue reference, or complete verification checklist, but it is m…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Description check
Explanation
The description provides a clear summary, rationale, and test plan. It does not include the requested hardware and environment details, issue reference, or complete verification checklist, but it is mostly complete and directly related to the changes.
Warning
Some tools did not complete. Review the errors below.
Clippy (1.99.0)
Clippy execution failed
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Summary
logind-zbuscrate with only theorg.freedesktop.login1.Managersurface used byasusdandasus-shutdown(inhibit, lid/power properties, prepare-for-shutdown/sleep signals).logind_zbus::{InhibitType, ManagerProxy}).Rationale
logind-zbus has been abandoned by @flukejones and it's not compatible with future versions of zbus (6+). As we don't need the full code but a small part of it it's better to pick it up ourselves and update alongside the rest of the package instead of waiting for the crate version.
Test plan
cargo check -p logind-zbus -p asusd -p asus-shutdown