You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
chore: cargo update to clear pulldown-cmark advisory - #441
RUSTSEC-2026-0414 requires pulldown-cmark >= 0.13.5; refresh
Cargo.lock so CI cargo audit passes again. Also restore the
missing trailing newline in aura_laptop so rustfmt --check
passes under the pinned 1.93 toolchain.
Signed-off-by: Marco Scardovi <scardracs@disroot.org>
No actionable comments were generated in the recent review.
Recent review info
Run configuration
Source mode: Auto
Repository: Unavailable
Branch: Unavailable
File: No configuration file from this repository applied
Commit: Unavailable
Layers: Repository UI
Review profile: ASSERTIVE
Plan: Advanced
Run ID: 45aab452-825d-42f0-ab26-f6216e6e4b26
Commits
Reviewing files that changed from the base of the PR and between f537fca and a98e128.
Files ignored due to path filters: 1
Cargo.lock is excluded by !**/*.lock
Files selected for processing: 1
asusd/src/aura_laptop/mod.rs
Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.
The title clearly identifies the main change: updating Cargo dependencies to address the pulldown-cmark security advisory.
Description check
The description explains the lockfile update, security advisory, remaining audit warnings, and test plan. It omits the template's hardware and environment fields and does not provide an issue number, …
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Description check
Explanation
The description explains the lockfile update, security advisory, remaining audit warnings, and test plan. It omits the template's hardware and environment fields and does not provide an issue number, but it is otherwise sufficiently complete and relevant.
Warning
Some tools did not complete. Review the errors below.
Clippy (1.99.0)
Clippy execution failed
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asusdSystem Daemon / D-BusfixFix a bug or an issue
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cargo.lockwithcargo updatesopulldown-cmarkmoves to 0.13.6 (>= 0.13.5), clearingRUSTSEC-2026-0414that was failing CIcargo audit.asusd/src/aura_laptop/mod.rssocargo fmt --checkpasses under the pinned rustc 1.93 toolchain.Audit warnings (not fixed here)
After this update,
cargo auditreports 0 vulnerabilities and 8 allowed warnings. They are not easy one-line fixes:clipboard-winzbus_names/zvariant/zvariant_derivebincodetyped-index-collections)pastepulp/rav1e) under Slintrustybuzz/ttf-parserusvg/resvgunder Slintgettext-rsi-slint-coreClearing those needs Slint and/or zbus major upgrades, not another lockfile bump.
Test plan
cargo auditjob passes (noRUSTSEC-2026-0414)cargo check --workspace/ existing build jobs stay greencargo audit→ 0 vulnerabilities, 8 warningspulldown-cmarkin lockfile is 0.13.6