Repository navigation
aura: add G615JPR (ROG Strix G16 2025) - #434
thenriques45-dot wants to merge 1 commit into
Conversation
Adds the ROG Strix G16 (2025) G615JPR to aura_support.ron. Same 0b05:19b6 4-zone keyboard as G615LM, plus the lightbar. Tested on CachyOS with asusctl 6.5.0: all basic modes, the 4 zones and the lightbar work. Closes OpenGamingCollective#398
|
No actionable comments were generated in the recent review.
 |
| Layer / File(s) | Summary |
|---|---|
Add G615JPR aura configuration rog-aura/data/aura_support.ron |
The configuration adds product ID 19b6, the g634j-per-key layout, five lighting modes, four basic key zones, no advanced type, and Keyboard/Lightbar power zones. |
Priority:
Estimated code review effort: 1 (Trivial) | ~5 minutes
Change: Feature · Severity of issue fixed: Medium
Suggested labels: rog-aura, enhancement
Suggested reviewers: ghoul4500, scardracs
Merge Risk: 
b4223
-
The configuration change has no established merge-blocking risk.
Pre-merge checks: 
-
Check name Status Explanation Title check Title "aura: add G615JPR (ROG Strix G16 2025)" directly names the main change: adding device support for the G615JPR to aura_support.ron. It is concise and specific, and the scope matches the single d… Linked Issues check The change addresses directly linked issue [ #398]. The newG615JPRentry uses product ID19b6,g634j-per-key, the five reported basic modes, four basic zones, and `power_zones: [Keyboard, Lightb…Out of Scope Changes check The supplied change summary shows one nine-line data entry in rog-aura/data/aura_support.ron. The entry directly implements device support requested by [#398]. No unrelated source, test, or document…Description check The description follows the repository template. It names the model (G615JPR), the change (one aura_support.ron entry), the reason (fallback to Static-only and lightbar off), and linked issue #398. It…Full details: Title check
-
Explanation
Title "aura: add G615JPR (ROG Strix G16 2025)" directly names the main change: adding device support for the G615JPR to aura_support.ron. It is concise and specific, and the scope matches the single data entry in the changeset. The model name and year are accurate to the PR description.
Full details: Linked Issues check
-
Explanation
The change addresses directly linked issue [
#398]. The newG615JPRentry uses product ID19b6,g634j-per-key, the five reported basic modes, four basic zones, andpower_zones: [Keyboard, Lightbar]. These fields provide model and device matching, four-zone keyboard support, and lightbar support instead of the Static-only default. The PR reports successful matching and lighting-mode and lightbar testing on the target hardware. Issue [#398] does not define a confirmed complete effect list, so the reported Armoury Crate effects do not require additional entries.
Full details: Out of Scope Changes check
-
Explanation
The supplied change summary shows one nine-line data entry in
rog-aura/data/aura_support.ron. The entry directly implements device support requested by [#398]. No unrelated source, test, or documentation changes are reported.
Full details: Description check
-
Explanation
The description follows the repository template. It names the model (G615JPR), the change (one aura_support.ron entry), the reason (fallback to Static-only and lightbar off), and linked issue
#398. It lists tested hardware, kernel, distro, and asusctl 6.5.0 results. The self-review box is checked. The description gives the context needed for a data-only change. Some template items are unchecked, but they are non-critical for a data-only change. The cargo checks were not run, and the author says so. The per-zone test could not be done because the option is greyed out. That is stated plainly.
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
coderabbitai
Bot
added
enhancement
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Description
Adds the ROG Strix G16 (2025) G615JPR to
aura_support.ron.It uses the same
0b05:19b64-zone keyboard as the G615LM, plus the lightbar. Without this entry, asusd falls back to a default config with only the Static mode and the lightbar turns off.Fixes #398
Tested Hardware & Environment
Tested with asusctl 6.5.0: asusd now matches the model ("Matched to G615JPR", "Matched to 19b6"), all basic modes (Static, Breathe, Rainbow Cycle, Rainbow Wave, Pulse) work, the per-zone option is greyed out in ROG Control Center, so the 4 zones couldn’t be tested individually, and the lightbar works.
Verification and testing:
cargo fmt --all -- --check)cargo clippy --all -- -D warnings/cargo check --all-targets)cargo test --all)cargo cranky)Data-only change (one new entry in
aura_support.ron), so the cargo checks were not run locally.